Problem/Motivation

Currently ViewsMenuLink sets manually the plugin related member variables (configuration, pluginId and pluginDefinition) when it should use, for consistency, the parent contructor

Proposed resolution

Use parent contructor instead of set manually the member variables

User interface changes

none.

API changes

none.

CommentFileSizeAuthor
#2 viewsmenulink_should-2579695-2.patch899 byteswillzyx

Comments

willzyx created an issue. See original summary.

willzyx’s picture

willzyx commented
Status: Active » Needs review
StatusFileSize
new viewsmenulink_should-2579695-2.patch899 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Agreed!

Yeah in total 2 less lines of code

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: viewsmenulink_should-2579695-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Reviewed & tested by the community

Meh

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This looks fine for 8.0.x, and less code to maintain.

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed 8aead03 on 8.1.x 
    Issue #2579695 by willzyx: ViewsMenuLink should use parent contructor...

  • catch committed a453159 on 
    Issue #2579695 by willzyx: ViewsMenuLink should use parent contructor...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.