Write tests that cover the standard term workflows. Should not cover IPE.

CommentFileSizeAuthor
#9 panelizer-n2579449-9.patch6.71 KBdamienmckenna
#5 panelizer-n2579449-5.patch6.41 KBdamienmckenna
#3 write_tests_to_cover-2579449-3.patch5.93 KBmglaman
#3 interdiff-2579449-3-2.txt1.22 KBmglaman
#2 write_tests_to_cover-2579449-2.patch5.47 KBmglaman

Comments

DamienMcKenna created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new write_tests_to_cover-2579449-2.patch5.47 KB

Initial term tests. Tests panelizering a vocab, allowing default view mode, enabling default view mode panel on perterm basis, and providing a default panel.

Customizing default panel next.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new interdiff-2579449-3-2.txt1.22 KB
new write_tests_to_cover-2579449-3.patch5.93 KB

I give up. Here's an addition to change layout. No idea how to add panes. Next step would be to override the layout on the term and verify that's all well.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Thanks!

FYI I've split up the tests into separate files, please rework your file accordingly.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panelizer-n2579449-5.patch6.41 KB

This should cover it.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Ah sorry :P did panelizer_term.test. I want to add onto it to modify the default and verify individual Panelizeration (I love the verbs/adjectives this module allows for) works.

DamienMcKenna queued 5: panelizer-n2579449-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: panelizer-n2579449-5.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panelizer-n2579449-9.patch6.71 KB

Rerolled. Also, I added some additional assertResponse() calls on each page request, just to ensure the page loaded as intended.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks mglaman!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.