Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Oct 2015 at 23:34 UTC
Updated:
17 May 2016 at 08:15 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
lauriiiComment #4
lauriiiLast one wont fly
Comment #6
mbayntonFixes the issue for me. Does this warrant a test?
Comment #7
lomo commented@mbaynton It has the "Needs tests" issue tag and I would say that the need is warranted (to help prevent regressions)
Comment #8
lauriiiComment #9
joelpittetThis should likely use ViewsRenderPipelineMarkup as it's in the pipeline so we can find these later when/if we find a better solution.
Comment #11
lauriiiHow about this one?
Comment #12
joelpittetWell it is rendering so it would be nice if it was a value object... but there is precedent to it like this with a
['#markup' => 'render array']A couple of examples that use #markup already.
\Drupal\views\Plugin\views\field\Dropbutton
\Drupal\views\Plugin\views\field\LinkBase
If the tests fail, blame Lauri:P
Comment #13
joelpittetComment #15
lauriiiComment #19
lauriiiComment #20
lauriiiComment #21
joelpittetThis was the approach I was thinking of from the start. It marks the ViewsRenderPipelineness for later review.
Comment #25
xjmThanks for tagging this for rc target triage! To have committers consider it for inclusion in RC, we should add a statement to the issue summary of why we need to make this change during RC, including what happens if we do not make the change and what any disruptions from it are. We can add a section
<h3>Why this should be an RC target</h3>to the summary.Comment #26
bigjim commentedEvaluated the issue for RC eligibility, felt it should be :D.
Made changes @xjm noted above to issue summary
Comment #27
ibullockI tested the patch manually and confirmed the issue is resolved by the patch. Added screenshots to the issue summary.
Comment #28
ibullockAdded a retest for php5.5_mysql5.5
Comment #29
mradcliffeI don't think this is rc eligible, but it should definitely be a candidate for rc target because it is a bug fix and not a coding standard, doc update, testing improvement or library update as written in https://www.drupal.org/core/d8-allowed-changes#rc.
Comment #30
webchickAgreed. One-line bug fix (+tests), fixing a regression that was introduced just before RC. Moving to RC Target and asking for forgiveness. ;)
Committed and pushed to 8.0.x. Thanks!
Comment #33
finex commentedHi, I've just discovered that even inline CSS styling is stripped from the global custom text field inside views. Is it a desidered behaviour?
Comment #34
lauriiiWe run that field through Xss:filterAdmin() which removes everything related to styles and javascript so it is expected behavior.
Comment #35
finex commentedOk, thanks :-)