Exactly what is said on the tin. A new unit test isn't necessary because a unit test exists that checks a collection of objects for being "stringable", and that existing collective method now calls the new method that tests one object at a time.

Quickfix because only a shorthand method is being added.

There is an API addition. Notes on when to use stringable vs. inbuilt is_string() added to the documentation.

CommentFileSizeAuthor
#8 interdiff.txt1.36 KBAki Tendo
#8 2579095--7.diff1.69 KBAki Tendo
#5 2579095--5.diff1.66 KBAki Tendo
#4 interdiff.txt910 bytesAki Tendo
#3 2579095--3.diff1.65 KBAki Tendo
stringable-patch.diff2.03 KBAki Tendo

Comments

Aki Tendo created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, stringable-patch.diff, failed testing.

Aki Tendo’s picture

Aki Tendo commented
Status: Needs work » Needs review
StatusFileSize
new 2579095--3.diff1.65 KB

That's odd. I'm going to resubmit the patch with a corrected typo in the comment text that needs to be done anyway - if this passes then something is wrong with the bots. Since the tests pass locally I don't see why it's failing on the bot.

Aki Tendo’s picture

Aki Tendo commented
StatusFileSize
new interdiff.txt910 bytes

Add interdiff.

Aki Tendo’s picture

Aki Tendo commented
StatusFileSize
new 2579095--5.diff1.66 KB

Missing static declaration.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah why not.

The last submitted patch, 3: 2579095--3.diff, failed testing.

Aki Tendo’s picture

Aki Tendo commented
StatusFileSize
new 2579095--7.diff1.69 KB
new interdiff.txt1.36 KB

Documentation adjustment - code unchanged from prior.

The last submitted patch, stringable-patch.diff, failed testing.

The last submitted patch, 3: 2579095--3.diff, failed testing.

Aki Tendo’s picture

Aki Tendo commented

Why are the new test bots trying to retest the older failed patches? Hiding them to try to stop this behavior.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 2579095--7.diff, failed testing.

Aki Tendo’s picture

Aki Tendo commented

What the Hell? The failure is in code I didn't touch nor is affect by the patch.

Aki Tendo queued 8: 2579095--7.diff for re-testing.

Aki Tendo’s picture

Aki Tendo commented
Status: Needs work » Reviewed & tested by the community

Code is now passing tests with no changes having been made to the prior approved patch, so reflagging. I'm guessing something odd was going with the testbots.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Test only code that this is just a very minor refactor with 0 risk and disruption. Committed 85fa64d and pushed to 8.0.x. Thanks!

  • alexpott committed 85fa64d on 8.0.x 
    Issue #2579095 by Aki Tendo: Create Inspector::assertStringable - a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.