Patch attached

CommentFileSizeAuthor
#10 add_support_for_https-2579043-10.patch719 bytesgielfeldt
#9 add_support_for_https-2579043-9.patch1.3 KBmiroslavbanov
#7 add_support_for_https-2579043-7.patch768 bytesmiroslavbanov
#4 add_support_for_https-2579043-4.patch647 bytesgielfeldt
https.patch1.02 KBgielfeldt

Comments

gielfeldt created an issue. See original summary.

gielfeldt’s picture

gielfeldt commented
Status: Active » Closed (works as designed)

Disregard. That was a stupid patch.

gielfeldt’s picture

gielfeldt commented
gielfeldt’s picture

gielfeldt commented
Status: Closed (works as designed) » Needs review
StatusFileSize
new add_support_for_https-2579043-4.patch647 bytes

Well ... only half-stupid. New patch attached.

miroslavbanov’s picture

miroslavbanov commented

Patch #4 looks interesting, will try it out.

miroslavbanov’s picture

miroslavbanov commented

Both patch #0 and #4 don't work. interpolateUrl is not used at all for generating video iframe, because it is taken from the oembed call instead. And the getEmbedInfo calls oembed from the backend, so protocol-relative urls don't work there.

miroslavbanov’s picture

miroslavbanov commented
StatusFileSize
new add_support_for_https-2579043-7.patch768 bytes

This one worked for me at least.

miroslavbanov’s picture

miroslavbanov commented

Having other problems. Video 23 allow for other domains that are not *.23video.com, but the certificate that is used is only valid for CN=*.23video.com. On PHP 5.6 SSL connection was changed to check certificate by default, see - http://php.net/manual/en/migration56.openssl.php. In order to fix that, I should pass stream context to not verify certificate. At this point I might as well use regex to make the url protocol-relative.

miroslavbanov’s picture

miroslavbanov commented
StatusFileSize
new add_support_for_https-2579043-9.patch1.3 KB

New attempt at fix. Also added back the change from #4, as I can see it might be used in some cases.

gielfeldt’s picture

gielfeldt commented
StatusFileSize
new add_support_for_https-2579043-10.patch719 bytes

It seems that the oembed code from 23video returns a src beginning with "//", hence being protocol agnostic, so I don't think the first part of the patch is relevant anymore. I've modified the second part slightly, since I've had issues with the protocol-less url, this being a stream wrapper and all.

Status: Needs review » Needs work

The last submitted patch, 10: add_support_for_https-2579043-10.patch, failed testing.

miroslavbanov’s picture

miroslavbanov commented

I don't see 23video returning protocol-relative urls. See example:
http://kk.23video.com/oembed/?url=http%3A%2F%2Fkk.23video.com%2Fvideo%2F...

gielfeldt’s picture

gielfeldt commented

I do: http://helbredsprofilendk.23video.com/oembed?url=http%3A//helbredsprofil...

But only in the iframe code. Maybe it's a setting on the 23video account?