Increase menu title maxlength to 255 in forms containing menu items

D8 is not affected

Patch tested with drupal's 7.x latest code. Its perfectly working. I am able to add menu title to length 255.

In Drupal 8 on the node form (I didn't check anywhere else) I see this:

<label for="edit-menu-title">Menu link title</label>
<input type="text" class="form-text" maxlength="128" size="60" value="" name="menu[title]" id="edit-menu-title" data-drupal-selector="edit-menu-title">

So maxlength = 128 still in Drupal 8.

In Drupal 8 i think it already 255. PFA Screenshot.

It is already working as designed.
Title length is 255 and is working fine in drupal 8 dev version.
Have any query. Feel free to reopen this issue.

in D8 actually only node-edit form is affected as #5 said

the patch is really,really simple =)

Nice! but this "max length" should be taken from title field definition, like #6 shows

I'm trying to figure out the right way to grab the max_length setting from the field definition, as per @andypost's comment. I don't know if this is the right approach to take, but it seems like this could be done by getting the default max_length setting from the base field definition in menu_ui_get_menu_link_defaults(). Here's a patch that does that.

Thanx! that looks a solution but the array of defaults should be the same depth, just add another key for max length

1. +++ b/core/modules/menu_ui/menu_ui.module
   @@ -219,7 +219,10 @@ function menu_ui_get_menu_link_defaults(NodeInterface $node) {
   +        'title' => array(
   +          'title' => $menu_link->getTitle(),
   +          'max_length' => $menu_link->getFieldDefinitions()['title']->getSetting('max_length'),
   

   that looks strange at least...
   maybe title and title_max_length is a better naming ... and better to keep them on the same level

2. +++ b/core/modules/menu_ui/menu_ui.module
   @@ -229,10 +232,17 @@ function menu_ui_get_menu_link_defaults(NodeInterface $node) {
   +    $menu_link = MenuLinkContent::create();
   +    $max_length = $menu_link->getFieldDefinitions()['title']->getSetting('max_length');
   

   would be create to prevent entity create because this affects performance seriously

3. +++ b/core/modules/menu_ui/menu_ui.module
   @@ -229,10 +232,17 @@ function menu_ui_get_menu_link_defaults(NodeInterface $node) {
   -      'title' => '',
   +      'title' => array(
   +        'title' => '',
   +        'max_length' => $max_length,
   

   changing this structure is APi change that is not allowed at RC stage

4. +++ b/core/modules/menu_ui/menu_ui.module
   @@ -312,7 +322,8 @@ function menu_ui_form_node_form_alter(&$form, FormStateInterface $form_state) {
   -    '#default_value' => $defaults['title'],
   +    '#default_value' => $defaults['title']['title'],
   +    '#maxlength' => $defaults['title']['max_length'],
   

   so let's keep the defaults just extended with with "title_max_length"

Thanks for reviewing! OK, I've implemented all your suggestions. Hopefully this one is better.

As for tests, I haven't created any test before so I'm not sure how to go about it. Should I add a new test file in core/modules/menu_ui/src/Tests? Could you point me in the direction of another similar test I can copy, and I'll have a go at creating a test for this? Thanks.

Ah, failed the testbot. Let's try this one.

Yep, that's better.
About tests, suppose you just need to add few lines to \Drupal\menu_ui\Tests\MenuTest::doMenuLinkFormDefaultsTest

Unhiding last patch

OK, I've added a couple of tests to \Drupal\menu_ui\Tests\MenuNodeTest::testMenuNodeFormWidget, since this patch affects the menu link on the node add and edit forms only. The tests use assertPattern to search for an input element with id="edit-menu-title" and maxlength=the maxlength setting pulled from the base field definition.

Looks great now!

Setting back to Needs review to prompt testbot.

Testbot is happy again, so setting back to RTBC

Reapplied patch and tested locally and all is well, so this looks like a testbot glitch. Submitting for retest.

And back to RTBC

This fix is done in a backwards compatible manor and has test coverage. As this is fixing a bug because it possible to create long menu titles through the API and then no be able to edit in the UI we should commit this to 8.0.x. However given that other entities might implement a similar integration with menu links as Node does I think this is worth a change record - https://www.drupal.org/node/add/changenotice?field_project=3060.

I have created change record. https://www.drupal.org/node/2659678

CR looks good

Committed b6f1612 and pushed to 8.0.x and 8.1.x. Thanks!

I rewrote the CR to focus on informing people about why we made the change and how a module might want to change their code to follow suit. https://www.drupal.org/node/2659678/revisions/view/9332968/9341898

+++ b/core/modules/menu_ui/src/Tests/MenuNodeTest.php
@@ -61,6 +61,11 @@ function testMenuNodeFormWidget() {
+    $this->drupalGet('node/add/page');
+    $this->assertPattern('/<input .* id="edit-menu-title" .* maxlength="' . $max_length . '" .* \/>/', 'Menu link title field has correct maxlength in node add form.');

@@ -171,6 +176,7 @@ function testMenuNodeFormWidget() {
+    $this->assertPattern('/<input .* id="edit-menu-title" .* maxlength="' . $max_length . '" .* \/>/', 'Menu link title field has correct maxlength in node edit form.');

this tests should be backported as well

Here's a patch that includes the backported tests.

review in progress

I think we miss test coverage in both D8 and D7 for the menu edit item screen.

Can we open a follow-up for that (as a child of this issue).

RTBC + 1, marked for commit.

Filed #2756723: Add tests for increased menu title maxlength to 255 in forms containing menu items

updated title maxlength to 255

#45: Thank you, but the patch in #38 already passed review and your patch lacks tests.

#38 needs a reroll including tests.

I don't think it actually needed a reroll, but I noticed that the new test code was trying (and failing) to create a node for no reason - which also doesn't match what the Drupal 8 patch was doing. So I fixed that plus a code comment fix.

This should be good to go as long as the tests pass/fail as expected.

After commit we could create a Drupal 7 change notice similar to https://www.drupal.org/node/2659678, although I think a release notes + CHANGELOG mention might be enough for this also.

Those look like the correct passes/fails, so moving this back to RTBC.

Tested that this correctly changes the maxlength to 255 in the node form and menu link form.

Committed and pushed to 7.x, thanks!