Problem/Motivation

After #2064191: Fix the 'target_bundle' field setting - 'target_bundles' are not validated when entity_reference is enabled, some references to dead target_bundle were left in the code.

Proposed resolution

Cleanup.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2578083-2.patch1.86 KBclaudiu.cristea

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
Related issues: +#2064191: Fix the 'target_bundle' field setting - 'target_bundles' are not validated when entity_reference is enabled
StatusFileSize
new 2578083-2.patch1.86 KB

Patch.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community
yched’s picture

yched commented

+1, thanks @claudiu.cristea !

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs work

There was a @todo left in EntityReferenceFieldTest as well.


    // @todo Implement a test case for invalid bundle references after
    //   https://www.drupal.org/node/2064191 is fixed.
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Reviewed & tested by the community

That @todo is not resolved, so it's still a... @todo. Eventually you can open a new issue for that because this one is only about fixing docs -- that one requires implement new tests.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue tags: +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 4694001 on 8.0.x 
    Issue #2578083 by claudiu.cristea: Followup: Clean docs after #2064191

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.