If you go into the admin section in bundle and edit a description and add certain tags like <p>, <span>, etc., get stripped the next time that you go into the admin bundles section.

CommentFileSizeAuthor
#5 use-field_ui-description-xss-2578005-5.patch1012 bytes8ballsteve
#2 keep_html_tags-2578005-1.patch770 bytesmchampsee

Comments

mchampsee created an issue. See original summary.

mchampsee’s picture

mchampsee commented
StatusFileSize
new keep_html_tags-2578005-1.patch770 bytes

The problem is that when the description field is populated it uses the filter_xss function which, by default, only allows 'a', 'em', 'strong', 'cite', 'blockquote', 'code', 'ul', 'ol', 'li', 'dl', 'dt', 'dd'. I changed that to the filter_xss_admin function which is more permissive and allows all the safe tags. Alternatively, I could also implement the text formats system that is otherwise used in Drupal (for instance, in the Body field).

mchampsee’s picture

mchampsee commented
Issue summary: View changes
mchampsee’s picture

mchampsee commented
Issue summary: View changes
8ballsteve’s picture

8ballsteve commented
StatusFileSize
new use-field_ui-description-xss-2578005-5.patch1012 bytes

Hi @mchampsee - I noted the same issue; seems to me this should follow the same principal as the core field description implementation.

see attached patch.

jaysonjaynes’s picture

jaysonjaynes commented

Was wondering if this will be incorporated into a future release or if there's a patch for the 7.x-1.2?

mchampsee’s picture

mchampsee commented
Version: 7.x-1.0 » 7.x-1.x-dev
Assigned: mchampsee » Unassigned
Status: Active » Reviewed & tested by the community

@8ballsteve - That patch looks good to me. I'm going to RTBC.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar

Checking the patch

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks @8ballsteve, @mchampsee for the patch.
Committed & Pushed to 7.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.