Follow-up to #2485579: Update JS library picturefill to 2.3.1

Current version: 2.3.1
New version: 3.0.1

https://github.com/scottjehl/picturefill

CommentFileSizeAuthor
#3 updated-picturefill-3.0.1-2577895-3.patch19.55 KBsdstyles

Comments

attiks created an issue. See original summary.

droplet’s picture

droplet commented
Title: Update JS library picturefill to 3.0.0 » Update JS library picturefill to 3.0.1
Issue summary: View changes
sdstyles’s picture

sdstyles commented
Status: Needs work » Needs review
StatusFileSize
new updated-picturefill-3.0.1-2577895-3.patch19.55 KB
attiks’s picture

attiks commented

Patch looks good, I'll propose we wait a couple of days to make sure it is the right version

attiks’s picture

attiks commented
Issue tags: +rc target

tagging for rc target

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -rc target +Needs framework manager review

See https://groups.drupal.org/node/484788 for more information on the rc target tag. I actually can't remember if we decided to update libraries during RC or not, so tagging for someone to check that.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Would be sad to ship with outdated version of the lib. 3.0 is better.

In any case if it can be updated that last patch is good to go.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

From what I saw in chat, 2/3 framework managers said +1 to updating libraries as much as we can prior to 8.0's release. Ergo...

Committed and pushed to 8.0.x. Thanks!

  • webchick committed d82d595 on 8.0.x 
    Issue #2577895 by sdstyles, attiks: Update JS library picturefill to 3.0...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -JavaScript, -Needs framework manager review