The label for the widget is missing. This is because a container form element is used as opposed to a fieldset (for example). Patch to follow.

CommentFileSizeAuthor
#10 Screen Shot 2015-09-29 at 8.47.48 am.png457.88 KBmikejw
#10 Screen Shot 2015-09-29 at 8.46.44 am.png430.99 KBmikejw
#2 geolocation-no-widget-label-2576023-2-8.patch569 bytesmikejw

Comments

mikejw created an issue. See original summary.

mikejw’s picture

mikejw commented
Status: Active » Needs review
StatusFileSize
new geolocation-no-widget-label-2576023-2-8.patch569 bytes

Here is the patch.

Status: Needs review » Needs work

The last submitted patch, 2: geolocation-no-widget-label-2576023-2-8.patch, failed testing.

Status: Needs work » Needs review

mikejw queued 2: geolocation-no-widget-label-2576023-2-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: geolocation-no-widget-label-2576023-2-8.patch, failed testing.

mikejw’s picture

mikejw commented

Not sure why this is failing - the tests run fine locally. Can someone please shed some light?

derjochenmeyer’s picture

derjochenmeyer commented

Don't know why the tests fail with "The test did not complete due to a fatal error."

#2576271: tests fail with "The test did not complete due to a fatal error."

Status: Needs work » Needs review

derjochenmeyer queued 2: geolocation-no-widget-label-2576023-2-8.patch for re-testing.

derjochenmeyer’s picture

derjochenmeyer commented

Test issue seems fixed. It seems the FormatterInterface changed...

@mikejw: Could you provide a before / after screenshot of your patch?

mikejw’s picture

mikejw commented
StatusFileSize
new Screen Shot 2015-09-29 at 8.46.44 am.png430.99 KB
new Screen Shot 2015-09-29 at 8.47.48 am.png457.88 KB

@derjochenmeyer: is this what you mean?

before
after

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Fixed

I guess i put it all in a container on purpose to have a cleaner interface, but it makes more sense to let developers decide. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.