Link module unit tests are never run because they are not discovered by the PHPUnit engine.
Move that tests in the right namespace so they can be run.
Before:
namespace Drupal\Tests\link\Plugin\Validation\Constraint;
After:
namespace Drupal\Tests\link\Unit\Plugin\Validation\Constraint;
| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Create a patch | Instructions | Done | |
| Update the issue summary | Instructions | Done | |
| Update the issue summary noting if allowed during the beta | Instructions | Done | |
| Add steps to reproduce the issue | Novice | Instructions | Done |
| Embed before and after screenshots in the issue summary | Novice | Instructions | Done |
None.
None.
None.
| Issue category | Bug because tests are so important that we do not want them to be ignored |
|---|---|
| Issue priority | Major because tests make the application more stable |
| Unfrozen changes | Unfrozen because it only changes tests. (All the link module tests) |
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2575559-after.png | 8.75 KB | duaelfr |
| #2 | 2575559-before.png | 7.79 KB | duaelfr |
| #2 | link_fix_tests_namespace_2575559-1.patch | 3.11 KB | duaelfr |
Comments
Comment #2
duaelfrComment #3
duaelfrComment #4
chx commented*shakes head*
Please file a followup where we explore how could we avoid this. (Possibly also avoid the "test" name in the classname. the @group annotation should be enough.)
Comment #5
duaelfrFollow-up issue created: #2575709: Change the tests discovery so we are sure we always run all the tests
Comment #6
catchCommitted/pushed to 8.0.x, thanks!