Problem/Motivation
- #2368987: Move internal page caching to a module to avoid relying on config get on runtime split off the Page Cache into a separate
page_cachemodule, but did not add aMAINTAINERS.txtnor a component. - #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!) added the
dynamic_page_cachemodule, aMAINTAINERS.txtentry was also created, but no component was added.
Proposed resolution
- Add
page_cacheMAINTAINERS.txtentry. - Add
page_cache.modulecomponent. - Add
dynamic_page_cache.modulecomponent.
Remaining tasks
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2575549-13.patch | 474 bytes | wim leers |
Comments
Comment #2
wim leersWe need this done so that people can actually report issues to the right components, and it's possible for maintainers to find these issues.
Comment #3
xjmAs a docs-only issue, this also can happen anytime, also.
Needs patch and review. :)
Comment #4
wim leersOh, great!
Comment #5
wim leersComment #6
wim leersComment #7
fabianx commentedI am happy to volunteer as page cache maintainer, too.
Maybe we also want znerol in there?
Comment #8
wim leers#7: Pinged znerol on IRC.
Comment #9
catchComment #10
wim leersSo, shall we add Fabianx to MAINTAINERS.txt for the Page Cache module then?
Comment #11
wim leers.
Comment #12
znerol commentedLate pong, I'm okay with co-maintaining it.
Comment #13
wim leersAwesome! Thank you :)
Assigning to Dries; needs either to be committed by Dries or an explicit approval comment from him here.
Comment #14
wim leersSomebody already the components :) Thank you, anonymous person!
Reducing issue scope accordingly.
Comment #15
xjmPer #2635844: Committers may add subsystem maintainers, any committer can now sign off on this change. This looks great to me!
Since this will be @znerol's first MAINTAINERS.txt entry -- congrats! And can you confirm that you are comfortable with the maintainer role outlined in the Drupal core governance policy and the specific subsystem maintainer responsibilities for this module? Thanks!
Comment #16
catchJust +1ing this since this is partly a split out of the cache subsystem which I'm listed on.
Comment #17
znerol commented@xjm I confirm.
Comment #18
wim leersComment #21
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!
Comment #22
wim leersThanks! Could you also add znerol to the "Assigned" dropdown's options?
Comment #23
catchDone!
Comment #24
wim leersThanks :)