Add warning message to Seven and Bartik that they can change in the future

Here's a patch.

+++ b/core/themes/seven/seven.info.yml
@@ -1,3 +1,7 @@
+# If you want to build on top of Seven, it's high recomended you copy the entire

high recomended = highly recommended

Minor change as per the comment number 3.
(If I understand correctly thats the only change require.)

Here's the draft change record: https://www.drupal.org/node/2582945

I've provided two options, maybe we should do that in the code comment as well? Is it good practice to link to the change record?

Whoo :)

I'm not sure what more could need to be done now, but if we want to nit-pick word changes, we can either:

1) Do it now and keep this ticket open for a month longer with 50 more comments, or
2) Call this finished and allow other people who feel like nitpicking reference this issue in the new issue they create.

I'm inclined to call this finished. ;-)

RTBC?

This can actually be RC eligible since it only adds documentation of a policy we've already agreed upon. Thanks!

Since this documentation helps set an important expectation for themers, tagging as an 8.0.1 target.

Do we have that separate issue for Bartik? I'd be fine with it in this patch as well, actually.

Should we put an @internal on a line by itself à la phpdoc? Nothing probably scans Twig templates atm, but it would be good to be consistent.

NR for #12. Thanks!

I have added the two options as mentioned by @LewisNyman.

I think probably the same should be done in Bartik. Also I added the link to the change record

Moving to Bartik queue. Lets also include this message with Bartik

I added the same to the Bartik theme as well.

Can be reviewed when the same has been implemented in Bartik theme as well. Status changed.

Looking into it.

Patch should include both Seven and Bartk.

Re-adding with change for both Bartik and Seven.

Tested it.. Looks fine. Just a suggestion.. The change record mentioned for Bartik is 'https://www.drupal.org/node/2582945' .. The thing is this node speaks about change in 'Seven' theme only and there is nothing mentioned about 'Bartik'. I am new to this, but do we need to modify the 'Change record' or edit the node-2582945 to include 'Bartik' theme.

Unassigning..

Thanks! The title should be updated to include Bartik, and component can just be theme system :)

+++ b/core/themes/bartik/bartik.info.yml
@@ -1,3 +1,16 @@
+# 1. Copy the whole of Bartik and rename it as your own admin theme. You

Bartik is not (generally) an admin theme. Take out the word "admin" here.

Hi,

Here I have applied the suggested changes from @cottser.

Thanks!

Sorry I wasn't able to use the right file format for the interdiff. :(

This is a copy of the patch and interdiff files from comment #26. I just renamed them accordingly too.

My apologies for the mistake on the interdiff.

Thanks!

This applies to both Bartik and Seven.

index a74f90c..99a5d65 100644
--- a/core/themes/bartik/bartik.info.yml

--- a/core/themes/bartik/bartik.info.yml
+++ b/core/themes/bartik/bartik.info.yml

+++ b/core/themes/bartik/bartik.info.yml
@@ -1,3 +1,16 @@

@@ -1,3 +1,16 @@
+# This theme is marked as @internal. It is intended to evolve and change over
+# minor releases.
+# Change record https://www.drupal.org/node/2582945.

The link to the change record is for Seven, we need to create one for Bartik.

Also @leolando.tan can you please unassign yourself from the issue when you finish working on it please.

I have created the Bartik change record at the link below; please can it be added to the patch :)

https://www.drupal.org/node/2673014

Hi @emma.maria, I'm very sorry. I'll do that on my future work with issues. Thank you very much!

Here I have also applied the Bartik change record link in Bartik's info.yml file.

Thanks!

I checked over the patch in #35 and the copy for both themes is now correct, plus both themes have separate change records. Setting this to RTBC.

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

Publish the change record