Based on the code from this module I have ported the upgrade hook to l10n_module. Therefore we need to prevent re-running this migration again. The easiest way is to set the schema version in system table to 7000.

CommentFileSizeAuthor
#5 2575231-5-killswitch.patch603 bytesSebCorbin

Comments

hass created an issue. See original summary.

hass’s picture

hass commented

Here it is:

function localizedrupalorg_update_7107() {
  UPDATE {system} SET schema_version='7000' WHERE name='l10n_packager';
}

I have not cloned this project, so please create the patch yourself.

hass’s picture

hass commented
Status: Active » Needs review
hass’s picture

hass commented
Status: Needs review » Postponed

Ah, we wait until the patch has been committed to l10n_server for now.

SebCorbin’s picture

SebCorbin commented
Title: Increase schema version so l10n_packager_update_7000 does not run "again" » Add killswitch so l10n_packager_update_7000 does not run "again"
Status: Postponed » Needs review
StatusFileSize
new 2575231-5-killswitch.patch603 bytes
hass’s picture

hass commented

The uninstall of this variable is missing. Why not setting the schema? It is a lot easier and cleaner and do not require any extra stuff.

  • drumm committed 09cf3ef on 7.x-1.x authored by SebCorbin 
    Issue #2575231 by SebCorbin: Add killswitch so l10n_packager_update_7000...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Since this is a site-specific module, we don't expect to be uninstalling it. The update itself can remove it.

And I can deploy this right away, doing the schema update later.

hass’s picture

hass commented

Not really, you already made the schema changes in past and now you need to skip the update hook or these will run again. Increasing the schema version in system table is a lot easier and cleaner code!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.