Problem/Motivation

Some tests are broken due to the lastest core changes.

Proposed resolution

Go throught the failing tests and fix them with simple mods.

Remaining tasks

Review, commit.

User interface changes

API changes

Data model changes

Original report by juanse254

CommentFileSizeAuthor
#7 interdiff-2-6-2574961.txt4.28 KBjuanse254
#7 Solve_issues_test-2574961-6.patch749 bytesjuanse254
#2 Solve_issues_test-2574961-2.patch4.13 KBjuanse254

Comments

juanse254 created an issue. See original summary.

juanse254’s picture

juanse254 commented
Status: Active » Needs review
StatusFileSize
new Solve_issues_test-2574961-2.patch4.13 KB

This will fix the tests.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs review » Reviewed & tested by the community

Looks good

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: Solve_issues_test-2574961-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Looks like one problem left but that's something else. Committed.

Please try to make more specific issue titles, like Using new :url placeholder to fix tests or something like that.

  • Berdir committed ceafb2a on 8.x-1.x authored by juanse254 
    Issue #2574961 by juanse254: Solve current issues that break tests
juanse254’s picture

juanse254 commented
Status: Fixed » Needs review
StatusFileSize
new Solve_issues_test-2574961-6.patch749 bytes
new interdiff-2-6-2574961.txt4.28 KB

I think its related, just forgot to add a (string) here is the patch.

  • Arla committed eb28cc0 on 8.x-1.x authored by juanse254 
    Issue #2574961 followup by juanse254: Solve current issues that break...
arla’s picture

arla commented
Status: Needs review » Fixed

Yeah looks good. Committed.

Status: Fixed » Needs work

The last submitted patch, 7: Solve_issues_test-2574961-6.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Closed (fixed)
juanse254’s picture

juanse254 commented