Update the hook_help for the Interface translation module again

Hi all,

I will be working on this today and hopefully there will be a patch :).

BR.

Hi all, here is the promised patch :)

Nevermind. I should have refreshed.

Hi,

I am getting this into review :)

Regards,
Lachezar

Applies cleanly but looking at some language tweaks. Will upload patch ASAP.

Hi,

So, the patch applies nicely, but I think we need to add additional sentence with link to the language edit form where you actually enable the functionality. Currently the text in the patch link only to the translations interface, but it could be confusing if you have not enable the option first.

Regards,
Lachezar

Added link & revised language.

And another patch with insight from ndobromirov.

New iteration for the text.
Added a link both to the translate interface and the languages configuration.

Note that this feature has nothing to do with default language configuration, but the convention that the strings in code are written in English. Because of this it works only for the English language.

Added a new patch :)

BR,
Nikolay Dobromirov.

Hi,

After review: the patch applies nice, but there is a spelling mistake marked below for the word "configured".

+++ b/core/modules/locale/locale.module
@@ -158,6 +158,8 @@ function locale_help($route_name, RouteMatchInterface $route_match) {
+      $output .= '<dd>' . t('You can override the default English interface text strings that are hard-coded in the PHP files of Drupal and contributed modules from <a href=":translate">User interface translation</a> page. This is available only for the English language when it has been cofigured from <a href="!languages">Languages</a> page.', array(':translate' => \Drupal::url('locale.translate_page'), '!languages' => \Drupal::url('entity.configurable_language.collection'))) . '</dd>';

There is a spell mistake.

Changed the status to Needs work.

1. +++ b/core/modules/locale/locale.module
   @@ -158,6 +158,8 @@ function locale_help($route_name, RouteMatchInterface $route_match) {
   +      $output .= '<dt>' . t('Overriding default English strings comming from code') . '</dt>';
   

   coming, not comming?

2. +++ b/core/modules/locale/locale.module
   @@ -158,6 +158,8 @@ function locale_help($route_name, RouteMatchInterface $route_match) {
   +      $output .= '<dd>' . t('You can override the default English interface text strings that are hard-coded in the PHP files of Drupal and contributed modules from <a href=":translate">User interface translation</a> page. This is available only for the English language when it has been cofigured from <a href="!languages">Languages</a> page.', array(':translate' => \Drupal::url('locale.translate_page'), '!languages' => \Drupal::url('entity.configurable_language.collection'))) . '</dd>';
   

   Not sure this text is very accurate. It misses "the" before both pages for one. Second, you can modify any translation for any language. The switch for English is disabled by default (and in fact was introduced) because it is a possible performance issue. So overriding English is only available for English because its overriding English :D

This looks pretty good! One nitpick:
with other English text string
==>
with other English text strings

Agreed. Current text sounds great.

Testbot fluke.

Thanks for your work on this issue!

This is a pretty long sentence; I had to read it several times before I understood it (and I still am not sure I do). Could we make this two sentences? Also, it's unclear what "this option" refers to.

How about something like:
You can also <em>override</em> the default English text strings on the <a href=":translate">User interface translation</a> page. Go to the <a href=":languages">languages</a> page... and enable the <em>This is the exact text in the UI</em> option [etc.]

https://groups.drupal.org/node/484788 Apparently this needs to be "rc deadline" because it changes translatable UI text strings

New patch changing that into hopefully better text... did not bother with interdiff because only 2 lines are in this patch anyway, and 1 is changed. Duh.

Its not really an RC deadline because new string additions are fine after RC as per the policy in my understanding. Anyway, not removing tag because its RTBC either way.

Quite clear now, thanks! Committed and pushed to 8.0.x.

Super, thanks all!