Follow-up to #2572019: Remove !placeholder in TourViewBuilder

Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

modules/user/user.api.php:    $name = t('User !uid', array('!uid' => $account->id()));

Proposed resolution

Remaining tasks

Agree that removing HTML support makes sense.

User interface changes

None

API changes

Date format strings no longer support adding HTML using the \ escape character.

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because at the moment date formats support HTML but it is escaped
Issue priority Major because part of the critical to remove !placeholder
Disruption Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this.
CommentFileSizeAuthor
#2 2572023-2.patch517 bytesswentel

Comments

dawehner created an issue. See original summary.

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2572023-2.patch517 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Absolutely perfect

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 30ac20b and pushed to 8.0.x. Thanks!

  • alexpott committed 30ac20b on 8.0.x 
    Issue #2572023 by swentel: Remove !placeholder in modules/user/user.api....

Status: Fixed » Needs work

The last submitted patch, 2: 2572023-2.patch, failed testing.

nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Needs work » Fixed

Already committed.
Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.