Vertical orientation icon is not centret.

-- A solution for this, is to remove min-height: 3em; --

CommentFileSizeAuthor
#6 d8_core-icon_not_centred-2572013-6-d8.patch595 byteser.manojsharma
toolbar-fixed_toolbar_vertical_tab-8.0.x.patch569 bytesmath8804

Comments

math8804 created an issue. See original summary.

math8804’s picture

math8804 commented
Title: Vertical orientation icon not in centret » Vertical orientation icon not centret
markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

This looks good. All working fine. Marking at RTBC.

markconroy’s picture

markconroy commented
Title: Vertical orientation icon not centret » Vertical orientation icon not centred

Status: Reviewed & tested by the community » Needs work

The last submitted patch, toolbar-fixed_toolbar_vertical_tab-8.0.x.patch, failed testing.

er.manojsharma’s picture

er.manojsharma commented
StatusFileSize
new d8_core-icon_not_centred-2572013-6-d8.patch595 bytes

Please review my patch

er.manojsharma’s picture

er.manojsharma commented
er.manojsharma’s picture

er.manojsharma commented
Assigned: Unassigned » er.manojsharma
er.manojsharma’s picture

er.manojsharma commented
Status: Needs work » Needs review
pingers’s picture

pingers commented
Status: Needs review » Needs work

An empty declaration isn't much help. The first patch looks better, but a screenshot to provide more context would be great. The first patch also needs re-rolling.

alexandr.khlopkov’s picture

alexandr.khlopkov commented
Status: Needs work » Reviewed & tested by the community
Bojhan’s picture

Bojhan commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs screenshots
pguillard’s picture

pguillard commented

I don't see icons not centred, and there is no min-height in toolbar.uessicons.theme.css.
I guess this has been resolved already ?

pingers’s picture

pingers commented
Status: Needs review » Closed (duplicate)

This was fixed in #2546196: Toolbar's orientation-toggling arrows broken by #2173527.