Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

modules/config_translation/config_translation.api.php:          'title' => t('!label field'),

Proposed resolution

Remaining tasks

Agree that removing HTML support makes sense.

User interface changes

None

API changes

Date format strings no longer support adding HTML using the \ escape character.

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because at the moment date formats support HTML but it is escaped
Issue priority Major because part of the critical to remove !placeholder
Disruption Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this.
CommentFileSizeAuthor
#8 2571941-8.patch773 bytesswentel
#4 2571941-2.patch780 bytesAyesh
#2 2571941-2.patch779 bytesswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

swentel’s picture

swentel CreditAttribution: swentel commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2571941-2.patch779 bytes

So should we just remove the ! here in the example ?

Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented
Issue summary: View changes

Isn't this !label placeholder supposed to be replaced with @label instead?

Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented
FileSize
2571941-2.patch780 bytes
swentel’s picture

swentel CreditAttribution: swentel commented

Well, then we need something that replaces the placeholder, it's a bit weird now no ?

Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented

Sorry you are absolutely right.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented 
+++ b/core/modules/config_translation/config_translation.api.php
@@ -53,7 +53,7 @@ function hook_config_translation_info(&$info) {
         $info[$entity_type_id . '_fields'] = array(
           'base_route_name' => 'entity.field_config.' . $entity_type_id . '_field_edit_form',
           'entity_type' => 'field_config',
-          'title' => t('!label field'),
+          'title' => t('@label field'),
           'class' => '\Drupal\config_translation\ConfigFieldMapper',

This was a copy of \config_translation_config_translation_info ... which was removed, let's remove this from the example.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
2571941-8.patch773 bytes

Replaced with 'Title' - makes more sense to me.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 156e903 and pushed to 8.0.x. Thanks!

  • alexpott committed 156e903 on 8.0.x 
    Issue #2571941 by swentel, Ayesh: Remove !placeholder in...

The last submitted patch, 4: 2571941-2.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 8: 2571941-8.patch, failed testing.

nevergone’s picture

nevergone CreditAttribution: nevergone commented
Status: Needs work » Fixed

Already committed.
Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.