Needs review
Project:
IP-based Determination of a Visitor's Country
Version:
2.1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Sep 2015 at 08:21 UTC
Updated:
3 Jul 2025 at 13:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sepgil commentedComment #3
sepgil commentedHere is my patch, which replaces the hard coded ftp urls with http urls.
Comment #4
tr commentedMoving this to 8.x-1.x.
I'm generally opposed to making the Internet === HTTP, but I'm not against adding HTTP as an *option* for those of you who want or need it.
Comment #5
ApacheEx commentedI have added an option to use HTTP connection. Here is a patch
Comment #7
ApacheEx commentednot sure if related, need to check
Comment #8
tr commentedI re-ran the test and it worked the second time - the failure may have been a testbot problem.
Comment #9
jazzfiction commentedThis proved really useful for me because my server's don't have access via FTP to the outside world. Once I implemented the patch, I was able to update the databases again. I implemented this patch against the latest dev version. Once I get back from Christmas vacation, I will try to update the patch so it is up to date with the current version.
Comment #10
tr commentedI made minor changes to some comments / text strings in #5. I'm happy with this patch, but I think there needs to be at least one test of the downloading using HTTP (actually, the patch uses HTTPS if the option is set ...). That way we will know if this feature ever breaks because of the ARIN server or because of other alterations to the ip2country module.
Comment #11
tr commentedForgot the patch ...
Comment #12
tr commentedOh, and since we're adding a config variable we need a hook_update_N() to ensure existing sites get the new value, and we need a update test for this hook as well.
New patch attached with the hook and the update test. Still needs a download test like I mentioned in #10.
Comment #13
klausiSplitting off the Drupal 7 issue into #3166385: Use HTTPS instead of FTP (D7 version) to not mix up patches here.
Comment #14
tr commentedMoving to current development branch.
Comment #15
ressinelRerolled #12 for 2.0.x-dev
Comment #16
tr commentedComment #17
tr commentedConverted #16 to a MR so that the automated testing can test the changes.
I had to make quite a few changes to re-roll it for 2.1.x.
Comment #19
tr commentedComment #20
andriy khomych commentedAttached patch from MR.
Comment #21
klausiMerge request updated. Uploading stable patch file here for composer patches.
I think the tests are still missing here.
Comment #22
hoanns commentedThis is obsolete now, since FTP access was discontinued. Should be closed as outdated
This patch fixes it: https://www.drupal.org/project/ip2country/issues/3532194