While working on #2568171: Upgrade to Twig 1.22 and implement our own cache class, @znerol was able to file a pull request upstream to fix the race condition upstream in Twig, so we no longer need to override loadTemplate to handle the race condition ourselves.
This also means we have less work to do in #2568181: [META] Update to Twig 2.x in Drupal 9.
Remove our override and update our cache class to match the new interface (has() has been removed).
TBD
n/a
Nothing relevant.
None
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | remove_race_condition-2571817-9.patch | 17.79 KB | hussainweb |
| #9 | interdiff-2-9.txt | 5.68 KB | hussainweb |
| #2 | remove_race_condition-2571817-2-test.patch | 17.18 KB | star-szr |
| #2 | remove_race_condition-2571817-2.patch | 2.61 KB | star-szr |
Comments
Comment #2
star-szrWe need to wait until the next Twig release to do something like this and use ~1.22.2 in our core/composer.json.
Comment #3
star-szrComment #6
star-szrComment #7
star-szrComment #8
star-szrWorking on this now.
Comment #9
hussainwebI used the -test patch from #2 and updated the version constraint to ^1.22.2 (so that it picks up everything until 2.0). I think that was the intention, right?
Comment #10
star-szrYeah that's fine. A comment would have been nice (or ping or something), I was about to post a patch. Anyway, thanks.
Comment #11
dawehnerNice!
Comment #12
hussainweb@Cottser, I read your comment again. For some reason I thought you said needs work now. Sorry for the confusion.
Comment #13
star-szr@hussainweb no worries it's been a long day! We can hug it out if you are at Barcelona.
Comment #14
alexpottCommitted dc95ff1 and pushed to 8.0.x. Thanks!