I would like to reference the StudyroomSpace objects within the studyroom_availability_day theme preprocessor. The forthcoming patch passes the StudyroomSpace objects instead of the space labels (the labels can be obtained from the objects).

CommentFileSizeAuthor
#2 spaces_theme_variable-2571103-2.patch1.2 KBmmikitka

Comments

mmikitka created an issue. See original summary.

mmikitka’s picture

mmikitka commented
Status: Active » Needs review
StatusFileSize
new spaces_theme_variable-2571103-2.patch1.2 KB
seworthi’s picture

seworthi commented

The only issue with this patch is I would like to see if this affects performance. I'm worried that loading (and passing) a lot of spaces around might effect page load times (in a site with many spaces). If not, if fine with it.

Scott

mmikitka’s picture

mmikitka commented

Scott - I don't expect much of a performance impact since the spaces were already being loaded prior to making my change. It's likely that the lifetime of the objects will be longer, but each Space object does not consume a lot of memory space, so I would expect the impact to be negligible.

matt

  • seworthi committed 739d1c0 on 7.x-1.x authored by mmikitka 
    Issue #2571103 by mmikitka: Pass spaces into studyroom_availability_day...
seworthi’s picture

seworthi commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.