There is a @todo item in modules/studyroom_availability/studyroom_availability.module: "@todo Fix this logic here. Issue if more that one location found.". This patch tries to address this @todo item, and improve the structure and documentation of the overall function.

Patch forthcoming.

CommentFileSizeAuthor
#4 studyroom_availability_search_mods-2570987-4.patch5.35 KBseworthi
#2 studroom_availability_search_mods-2570987-2.patch5.74 KBmmikitka

Comments

mmikitka created an issue. See original summary.

mmikitka’s picture

mmikitka commented
Status: Active » Needs review
StatusFileSize
new studroom_availability_search_mods-2570987-2.patch5.74 KB
mmikitka’s picture

mmikitka commented

@seworthi - Can you please provide an update on this?

seworthi’s picture

seworthi commented
StatusFileSize
new studyroom_availability_search_mods-2570987-4.patch5.35 KB

Here is the patch to address these issues.

Status: Needs review » Needs work

The last submitted patch, 4: studyroom_availability_search_mods-2570987-4.patch, failed testing.

The last submitted patch, 4: studyroom_availability_search_mods-2570987-4.patch, failed testing.

  • seworthi committed dd7d4b0 on 7.x-1.x 
    Issue #2570987 by mmikitka, seworthi: Improve documentation and logic of...
seworthi’s picture

seworthi commented
Assigned: Unassigned » seworthi
Status: Needs work » Fixed

Improved some logic and documentation in availability module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.