Closed (cannot reproduce)
Project:
Drupal core
Version:
8.0.x-dev
Component:
toolbar.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Sep 2015 at 07:54 UTC
Updated:
13 Oct 2015 at 12:19 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
juanse254 commentedComment #3
juanse254 commentedDeleting the this sets the div to upper.
Comment #4
giancarlosotelo commentedI think is not the best solution. This div cannot disappear, is the wrapper of the elements in the menu. We just have to move it.
The problem is that the toolbar is taking the position of the body which have some margin left.
So I suggest to change the position from absolute to fixed in.
Comment #5
juanse254 commentedMaybe you are right, this also works. Im adding the patch here, some feedback needed.
Comment #6
andread commentedThis solution solves the original problem, but gives problems, when scrolling on a longer page.
The buttons on the page gets positioned on top of the navigation toolbar.
Comment #7
andread commentedComment #8
lucastockmann commentedNevermind, didn't saw what Andrea was mentioning...
Comment #9
lucastockmann commentedSo back to "Needs work".
AndreaD:
Comment #10
giancarlosotelo commentedThe toolbar is working well in other pages. So basically the problem is that in contextual pages(?) a class that has a position relative is added to the body, and this is moving the toolbar inside the body, just in those pages.
So the possible solution is to remove the added class or change the style there.
Comment #11
andread commentedIf we are keeping the position, but changing z-index, it solves the problem, without causing more.
Needs review.
Comment #12
juanse254 commentedThis still needs to be tested completely but seems to work.
Edit: You cant just fix the Z-Index, because despite it does the job the div remains in the same position which is not where its meant to be(Left).
Comment #13
juanse254 commentedIm sorry that patch 12 included unrelated stuff :).
Comment #16
giancarlosotelo commentedOk, I think last patch solve the issue without problems.
Comment #17
alexpottI think we need to confirm that this does not break the toolbar on multiple browsers and multiple os's
Comment #18
edurenye commentedTested in linux with chrome, chromium, firefox, firefox developer edition (check diferent screen sizes), opera and Browser. And it works fine in all them.
@juanse254 Tried in Mac, so we just need somone else that try it in Windows.
I think this tests are kind of a review, so it needs review.
Comment #19
juanse254 commentedTested for 3 days now in Chrome with OSX, also tested with safari and firefox in OSX. Everything works fine.
Comment #20
edurenye commentedI tested it in Windows 10 with Edge, Chrome, Firefox and Opera.
Works perfect everywhere, so goes to RTBC.
Comment #21
alexpottCommitted 2acfed8 and pushed to 8.0.x. Thanks!
@edurenye in future any chance you can post screenshots - it makes it easier to confirm the testing - thanks.
Comment #23
edurenye commentedWe realise that this breaks another thing, a lot of things use contextual-region, so it breaks the edit button in the nodes.
I think that maybe it should be set in toolbar-vertical class as it is ther just in that case.
Sorry to not be able to see that before, I just tested in the forms all the time, and I didn't get that detail.
Comment #24
juanse254 commentedim not sure if that is supposed to go there..
Comment #25
edurenye commentedMaybe better here.
I'll try to test as much as I can.
Comment #26
edurenye commentedComment #27
juanse254 commentedOkay, i think this is more acurate. After disscusion with edurenye we realized that the commited patch was breaking the edit buttons because the contextual-region is too widely used, changing the position just when the toolbar is vertical and active makes more sense.
Edit: Please use patch 24, as thats the one that fixes the issue. As tested 25 and 27 fail sometimes, please review the patch 24 and assert that nothing is wrong.
Comment #28
juanse254 commentedComment #30
juanse254 commentedComment #31
edurenye commentedLets's solve this in a follow up #2577561: Open configuration options button disappears when trying to click it
Comment #32
alexpottAs this as caused a regression - I've reverted this.
Comment #34
edurenye commentedI think this should work, I tested in Windows and Linux in all my browsers, but seeing the last time, always is posible to miss somthing, so help me to test a bit please.
Comment #35
codonet commentedTested manually on Windows with
Opera 32.0
Firefox 41.0
Google Chrome 45.0
IE 11.0
Works ok.
I am new contributor. This issue is not assigned to anyone? Stays this way?
Comment #36
codonet commentedComment #37
codonet commentedSorry. I am new contributor (learning). Now I tested it with Simply TestMe so that I am sure that I am testing the right thing. Works ok on the browsers I mentioned in the previous comment. Since I am new somebody else can change the status.
Comment #38
edurenye commentedDid you test that it works or that it didn't break anything else? We need to test that last thing more I think to not have again the same problem, but I don't know how to tell what is tested and what not, maybe we should try to identify the cases when this css is active.
Also maybe we need to test in tablets?
We don't need to assign it to anybody as it needs to be tested.
Comment #39
juanse254 commentedcant reproduce anymore.