Closed (fixed)
Project:
Search API attachments
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2015 at 13:35 UTC
Updated:
3 May 2018 at 14:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
izus commentedThanks pebosi for spotting this need, i confirm nothing was done for supporting comments.
can you follow the example of search_api_attachments submodules to provide a patch that adds a submodule to support attachemnts in comments ?
i think example of entityreference submodule is the closest to your need here.
Thanks
Comment #3
grimreaperHello,
Here is a patch that allow to index file fields on node comments.
I encountered a fatal error when trying to create a search api index on comment directly. I suppose it is a bug in search api and I also supposed that the common use case of this feature is to add the comment attachment on node indexes.
To mark the node to be reindexed, I use the hooks comment_insert/update/delete without restriction. Maybe it will be a performance issue. We can discuss of a solution to be more precise if you want.
Note: I begin to be fed up to have multiple of sub-modules to maintain (help maintaining :)) and that each sub-modules have 90% of code in common.
Thanks for the review.
Comment #4
izus commentedhi pebosi,
were you able to test this patch? is it working for you ?
Comment #6
izus commentedhi,
merged #3 to not loose Grimreaper's effort on this.
Thanks