On the heels of #2569469: [Policy, no patch] No need to provide an upgrade path for Migrations, we will not be able to get certain tests to pass until migrations are not in the fixtures we use for update path testing. drupal-8.filled.standard.php, at least, contains migrations which need to be removed.

CommentFileSizeAuthor
#7 2569605-7.patch1.12 MBphenaproxima
#5 2569605-5.patch1.12 MBphenaproxima
#2 2569605-2.patch1.11 MBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2569605-2.patch1.11 MB

Removed all migrate.migration.* entities from the config table.

Status: Needs review » Needs work

The last submitted patch, 2: 2569605-2.patch, failed testing.

The last submitted patch, 2: 2569605-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2569605-5.patch1.12 MB

Please gawd...

neclimdul’s picture

neclimdul
He/Him
commented

We should probably empty and leave the update method with a comment.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2569605-7.patch1.12 MB

Done.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

non-db changes look straightforward.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Related issues: +#2577801: Re-add migration entities to update path test fixtures when Migrate is stable

Created a follow-up issue to re-add the migrations once Migrate is stable. #2577801: Re-add migration entities to update path test fixtures when Migrate is stable

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Great, with the creation of that issue I think we can proceed here. This will certainly help us during RC to not have to figure out strange Migrate upgrade path issues (doesn't come up often, but when it does happen it's tricky to work out).

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 5355f8c on 8.0.x 
    Issue #2569605 by phenaproxima, neclimdul, catch: Remove migrations from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.