Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

See https://www.drupal.org/node/2566503#comment-10325457
and https://www.drupal.org/node/2566503#comment-10334587

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 interdiff.txt667 bytesdawehner
#9 25692790-9.patch2.15 KBdawehner
#8 after.png43.67 KBizus
#8 before.png45.2 KBizus
#6 interdiff.txt1.35 KBdawehner
#6 2569279-6.patch2.16 KBdawehner
#3 2569279-3.patch2.14 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Parent issue: #2568603: Replace remaining !placeholder for Non-URL HTML outputs only in core/lib/Drupal/Core/Database/Driver/pgsql/Install/Tasks.php » #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Active » Needs review
FileSize
2569279-3.patch2.14 KB

This is the only non URL usage.

Status: Needs review » Needs work

The last submitted patch, 3: 2569279-3.patch, failed testing.

The last submitted patch, 3: 2569279-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs work » Needs review
FileSize
2569279-6.patch2.16 KB
interdiff.txt1.35 KB

Glad we have test coverage.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Priority: Major » Critical

This is part of the critical meta.

izus’s picture

izus CreditAttribution: izus commented
Issue summary: View changes
Status: Needs review » Needs work
FileSize
before.png45.2 KB
after.png43.67 KB

Hi,
I tested the patch and the image is no more displayed.
See before and after captures

before :
before
after :
after

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs work » Needs review
FileSize
25692790-9.patch2.15 KB
interdiff.txt667 bytes

Ups ...

izus’s picture

izus CreditAttribution: izus commented
Status: Needs review » Reviewed & tested by the community

Tested it again manually, and it seems good to me :)
Thanks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Manually tested too it works. Committed afffe84 and pushed to 8.0.x. Thanks!

  • alexpott committed afffe84 on 8.0.x 
    Issue #2569279 by dawehner, izus: Replace remaining !placeholder for Non...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.