Migrate the following search variables. The same values are present in D6 and migrated with d6_search_page.

It may be possible to combine the D6 and D7 migrations.

node_rank_comments
node_rank_promote
node_rank_recent
node_rank_relevancy
node_rank_sticky
node_rank_views

CommentFileSizeAuthor
#16 2569245-16.patch5.78 KBquietone
#16 interdiff-2569245-12-16.txt941 bytesquietone
#12 2569245-12.patch5.78 KBquietone
#7 interdiff-2569245-4-7.txt1.08 KBquietone
#7 2569245-7.patch6.59 KBquietone
#4 2569245-4.patch6.01 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Parent issue: » #2500511: Upgrade path for Search 7.x
quietone’s picture

quietone commented
Category: Bug report » Task

Make this a 'task', like the other Variable to config issues.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2569245-4.patch6.01 KB

Only have time to upload - have to catch a bus.

Status: Needs review » Needs work

The last submitted patch, 4: 2569245-4.patch, failed testing.

The last submitted patch, 4: 2569245-4.patch, failed testing.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2569245-7.patch6.59 KB
new interdiff-2569245-4-7.txt1.08 KB

Well, I caught the bus, but left behind a typo and forgot to change MigrateDrupal6Test.

Status: Needs review » Needs work

The last submitted patch, 7: 2569245-7.patch, failed testing.

quietone queued 7: 2569245-7.patch for re-testing.

quietone’s picture

quietone commented
Status: Needs work » Needs review
quietone’s picture

quietone commented
Status: Needs review » Active
Issue tags: +Needs reroll
quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2569245-12.patch5.78 KB

Rerolled but making the interdiff fails.

The change was to move these changes made to the d6 test to the new d7 test. And change 'd6_search_page' to 'search_page'

   /** @var \Drupal\migrate\Entity\MigrationInterface $migration */
    $migration = \Drupal::entityManager()
      ->getStorage('migration')
      ->loadUnchanged('d6_search_page');
    // Indicate we're rerunning a migration that's already run.
    $migration->getIdMap()->prepareUpdate();
    $this->executeMigration($migration);
quietone’s picture

quietone commented
Issue tags: -Needs reroll
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Variable to config: search.page [d7] » [D7] Migrate search pages

No interdiff? No problem. :) I have a couple of minor things but this looks great otherwise.

  1. +++ b/core/modules/search/src/Tests/Migrate/d7/MigrateSearchPageTest.php
@@ -0,0 +1,74 @@
+  /**
+   * The modules to be enabled during the test.
+   *
+   * @var array
+   */
+  static $modules = array('node', 'search');

    Should be public static, and {@inheritdoc} for the doc comment. 

  2. +++ b/core/modules/search/src/Tests/Migrate/d7/MigrateSearchPageTest.php
@@ -0,0 +1,74 @@
+    $search_page = entity_load('search_page', $id);

    entity_load() is deprecated -- use the static SearchPage::load() method instead.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

Whoops.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2569245-12-16.txt941 bytes
new 2569245-16.patch5.78 KB

All fixed.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Preemptively RTBC :) DrupalCI passed the previous patch, so I see no reason why it shouldn't pass this one. Awesome work @quietone -- thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed b904c4b on 8.0.x 
    Issue #2569245 by quietone, phenaproxima: [D7] Migrate search pages

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.