Replace remaining !placeholder for Non-URL HTML outputs only for $entity->label()

1. +++ b/core/lib/Drupal/Core/Menu/menu.api.php
   @@ -388,7 +388,7 @@ function hook_contextual_links_alter(array &$links, $group, array $route_paramet
   -    $links['menu_edit']['title'] = t('Edit menu: !label', array('!label' => $menu->label()));
   +    $links['menu_edit']['title'] = t('Edit menu: @label', array('@label' => $menu->label()));
   

   Menu labels are escaped when they are displayed in menus so they definitely should be here.

2. +++ b/core/modules/aggregator/src/FeedViewBuilder.php
   @@ -114,7 +114,7 @@ public function buildComponents(array &$build, array $entities, array $displays,
   -          '#title' => t('!title feed', array('!title' => $entity->label())),
   +          '#title' => t('@title feed', array('@title' => $entity->label())),
   

   So here we are saved by the current behaviour of !placeholder as $entity->label() is not marked safe before doing this. If we had the Drupal 7 behaviour this would be exploitable. Therefore I think we need to ensure there is test coverage for this in the aggregator module. I think escaping is the correct behaviour for aggregator titles.

3. +++ b/core/modules/config_translation/src/FormElement/FormElementBase.php
   @@ -100,8 +100,8 @@ protected function getSourceElement(LanguageInterface $source_language, $source_
   -      '#title' => $this->t('!label <span class="visually-hidden">(!source_language)</span>', array(
   -        '!label' => $this->t($this->definition->getLabel()),
   +      '#title' => $this->t('@label <span class="visually-hidden">(!source_language)</span>', array(
   +        '@label' => $this->definition->getLabel(),
   
   @@ -162,8 +162,8 @@ protected function getSourceElement(LanguageInterface $source_language, $source_
   -      '#title' => $this->t('!label <span class="visually-hidden">(!source_language)</span>', array(
   -        '!label' => $this->t($this->definition['label']),
   +      '#title' => $this->t('@label <span class="visually-hidden">(!source_language)</span>', array(
   +        '@label' => $this->definition['label'],
   

   Wowzer!?!?! this was using t() as a way to mark safe. And I agree that the definition label should be escaped.

4. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationOverviewTest.php
   @@ -116,8 +117,8 @@ public function testMapperListPage() {
   -      $title = t('@label @entity_type', array('@label' => $test_entity->label(), '@entity_type' => $entity_type->getLowercaseLabel()));
   -      $title = t('Translations for %label', array('%label' => $title));
   +      $title = $test_entity->label() . ' ' . $entity_type->getLowercaseLabel();
   +      $title = 'Translations for <em class="placeholder">' . Html::escape($title) . '</em>';
          $this->assertRaw($title);
   

   Nice we have some test coverage.

Setting to needs work for adding test coverage of the aggregator entity label in the feed icon.

Working on the test coverage

Patch looks good and RTBCing with a help of #10. Btw interdiff has code which is not included in the patch so don't get confused of that :)

+++ b/core/modules/config_translation/config_translation.module
@@ -8,6 +8,7 @@
+use Drupal\Core\StringTranslation\TranslationWrapper;

Unneeded?

+++ b/core/modules/config_translation/config_translation.module
@@ -115,7 +116,7 @@ function config_translation_config_translation_info(&$info) {
+          'title' => '@label field',

+++ b/core/modules/config_translation/src/ConfigEntityMapper.php
@@ -154,11 +154,7 @@ public function setEntity(ConfigEntityInterface $entity) {
+    return $this->entity->label() . ' ' . $this->pluginDefinition['title'];

where does @label come from here? In https://www.drupal.org/files/issues/interdiff-120-122.txt I thought it was set in ConfigEntityMapper::getTitle?

Otherwise this all looks good to me

Oops, didn't mean to RTBC yet, just wondering about the @label field bit?

Committed 0f6f909 and pushed to 8.0.x. Thanks!

This is part of the critical meta.

Note we've have issues with respect to entity labels going back years.