Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only
core/lib/Drupal/Core/Database/Driver/pgsql/Install/Tasks.php (those two seem okay to combine in one patch).
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff.txt | 1.05 KB | dawehner |
#13 | 2568603-13.patch | 2.36 KB | dawehner |
#5 | 2568603-3.patch | 2.46 KB | dawehner |
#5 | Screen Shot 2015-09-15 at 13.47.41.png | 243.18 KB | dawehner |
#5 | Screen Shot 2015-09-15 at 13.47.41.png | 243.18 KB | dawehner |
Comments
Comment #2
dawehnerComment #3
dawehnerLet's get started
Comment #4
pguillard CreditAttribution: pguillard commentedComment #5
dawehnerHere is a screenshot with all of them hacked in temporarily.
Just in case someone asked, we could use (new Link()) but therefore we need to fix the UnroutedUrlAssembler, see #2568773: Add $options['base_url'] support to the unrouted URL assembler
Comment #6
dawehner@pguillard
Did you tried whether this actually works, because I doubt it.
Comment #7
pguillard CreditAttribution: pguillard commented@dawehner : no, I didn't try
Comment #8
dawehner@pguillard
So yeah in your example the
<code>
would have been escaped and by that not what you actually want. You want $query to be HTML wrapped.Comment #9
xjmComment #10
xjmThat looks like it wants a test added too.
Comment #11
xjm(Embedding @dawehner's screenshots.)
Comment #12
xjmSo that $base_url is not being used... is the link broken, or not?
Comment #13
dawehnerThank you for your reviews xjm!!
I fear testing this will be incredible hard. You would basically have to compile a Mysql server without utfmb4 support. PHP is a programming language, so yes, we could do that,
but feels a little bit too much as requirement for this issue. The same was decided on the utfmb4 issue which introduced this particular code.
Ah yeah I was experimenting with the url generator code. Let's keep it as straightforward as possible and use exactly the same as HEAD, which works!
You link to a relative URL, and "core" is the current base path as seen by your browser. Everything is fine. I tested it on d8.dev and localhost/d8 and clicked on the link.
Comment #14
xjmLOL fair enough.
This seems completely sufficient to me then. Thanks!
Comment #15
alexpottCommitted 333977e and pushed to 8.0.x. Thanks!
Comment #17
alexpott