Found in #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests
Part of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand.

core/modules/aggregator/src/Tests/UpdateFeedItemTest.php uses !placeholder unnecessarily.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because its a child issue of a task
Issue priority Major, because its a child of a major
CommentFileSizeAuthor
#2 2568015.2.patch825 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2568015.2.patch825 bytes

The other instances of !placeholder are covered in #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Simple enough. The message doesn't add any information.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

+1 for killing unhelpful assertion messages. Committed and pushed to 8.0.x. Thanks!

  • xjm committed 227f520 on 8.0.x 
    Issue #2568015 by alexpott, dawehner: Replace !placeholder in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.