$query = $this->connection
->queryRange('SELECT session FROM {sessions} WHERE sid = :sid', 0, 1, ['sid' => Crypt::hashBase64($sid)]);
should be
$query = $this->connection
->queryRange('SELECT session FROM {sessions} WHERE sid = :sid', 0, 1, [':sid' => Crypt::hashBase64($sid)]);
I don't know why it works even without the semicolon, but I think it's better to use the same value as the placeholder.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | typo_in-2567835-11.patch | 711 bytes | alvar0hurtad0 |
| #4 | typo_in-2567835-4.patch | 711 bytes | lussoluca |
| #2 | typo_in-2567835-2.patch | 561 bytes | lussoluca |
Comments
Comment #2
lussolucaComment #4
lussolucaOps, wrong patch
Comment #5
lussolucaComment #7
valthebaldPatch looks good, but I wonder how the current code can even work?
Comment #8
lussolucaI don't know, maybe an undocumented feature of MySQL?
Comment #9
valthebaldThis is indeed undocumented feature of PDO (see http://stackoverflow.com/questions/9778887/is-the-leading-colon-for-para...)
TL;DR: we should always use colon in parameter name - PDO adds colon to parameter name if it's missing, but this may stop working in future PHP releases.
Comment #11
alvar0hurtad0Here's the patch (maybe again).
Comment #12
valthebaldLooks like testbot hiccup. You didn't need to create a new patch, retesting the old one should be enough.
I wonder if there is a way to find similar typos in the core, if they exist?
Comment #13
alvar0hurtad0I fac the two parches are not equal, #11 has an extra blank space on the comments than #4
Comment #14
valthebald@alvar0hurtad0: next time please use interdiff :)
Comment #15
xjmTrippy. Thanks @valthebald for checking how that could possibly ever work; otherwise I would have suspected a bug and missing test coverage.
Committed and pushed to 8.0.x. Thanks!