_system_is_incompatible() was last used in Drupal 6.x releases and has not been called anywhere in Drupal core since #229129: System module page *seriously* broken was committed in 2008.

CommentFileSizeAuthor
#2 remove_system_is_incompatible-1.patch1.29 KBAntti J. Salminen
remove_system_is_incompatible.patch1.42 KBAntti J. Salminen

Comments

Antti J. Salminen created an issue. See original summary.

Antti J. Salminen’s picture

Antti J. Salminen commented
StatusFileSize
new remove_system_is_incompatible-1.patch1.29 KB

Let's try again... had an extraneous newline removal in the patch.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks for catching this! Just out of sheer curiosity, do we have a test module for incompatible PHP versions?

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Nice catch. Normally we'd want a change record, and during the beta we'd want to deprecate instead of removing the function, but given this is prefixed by an underscore and so obsolete, I don't think it's necessary in this case.

@chx, for tests in D8, there's SystemRequirementsTest.

Committed and pushed to 8.0.x. Thanks!

  • xjm committed 4eaec81 on 8.0.x 
    Issue #2567767 by Antti J. Salminen: Remove unused function...
chx’s picture

chx commented

Nope, we do not have a test like what I asked we have DependencyTest::testIncompatibleCoreVersionDependency but not testIncompatiblePhpVersionDependency . Oh well.

Antti J. Salminen’s picture

Antti J. Salminen commented

I created an issue for the test chx suggested and started on it: #2567861: Add test for enabling modules with incompatible PHP version dependency

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.