Somehow Classy's page template ended up with two highlighted regions. It might have been around this issue #2470807: Rename the default "Messages" region for all themes to "Highlighted" but I don't see a direct cause there. I think maybe the messages region was renamed highlighted, but there was already a highlighted region? No idea why the System template didn't have it then.

One a scale of 1 to WTF ... well, it aint closer to 1.

We should also check the other page templates to make sure we didn't make a similar mistake.

In the initial patch I removed the second one, which keeps highlighted in the same place as in the System template.

Files: 
CommentFileSizeAuthor
removeduphighlighted.patch471 bytesdavidhernandez
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 112,549 pass(es). View

Comments

davidhernandez created an issue. See original summary.

lauriii’s picture

Status: Needs review » Reviewed & tested by the community

Both Bartik and Seven override Classys page.html.twig template so there is no potential visual changes in them. Also having highlight region in the same place as in System module makes sense.

davidhernandez’s picture

I also looked at the install and maintenance pages and didn't see any duplicates there.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9822652 and pushed to 8.0.x. Thanks!

    <div class="layout-content">

      {{ title_prefix }}

I think we can remove the blank line here in both classy and system's template but just in case not fixing on commit - it's a nice novice followup.

  • alexpott committed 9822652 on 8.0.x
    Issue #2567489 by davidhernandez: Classy's page template has two...
davidhernandez’s picture

Status: Fixed » Reviewed & tested by the community

I think we can forgo the follow up because the title conversion issue will delete them from both templates, since that space is right before the title prefix.

#2476947: Convert "title" page element into a block

davidhernandez’s picture

Status: Reviewed & tested by the community » Fixed

oops

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vaplas’s picture

Version: 8.0.x-dev » 9.x-dev

--- Why branch switches? I did not do it :) --

The documentation of Regions still duplicate highlighted

/core/themes/classy/templates/layout/page.html.twig (lines 31 and 34)

 * Regions:
 * - page.header: Items for the header region.
 * - page.highlighted: Items for the highlighted region.
 * - page.primary_menu: Items for the primary menu region.
 * - page.secondary_menu: Items for the secondary menu region.
 * - page.highlighted: Items for the highlighted content region.

Add info:

In 7 themes used both variants

  • bootstrap_lite
  • casper
  • guru
  • moonwalk
  • newsflash
  • pistachio
  • teatheme

 
In 8 themes used only "page.highlighted: Items for the highlighted region."

  • bootstrap_barrio
  • integrity
  • light_skeleton
  • nero
  • newsplus_lite
  • nexus
  • rainbow
  • wet4

 
In other themes used only "page.highlighted: Items for the highlighted content region."

davidhernandez’s picture

Version: 9.x-dev » 8.0.0

I don't know what you are asking about the branch switch. No one switched branches, and this issue was fixed a long tim ago.

For the documentation mistake, please open a new issue.