Make Aggregator module pass Coder Review [#2567365]

This issue is a recreated one based on #1512434: Make Aggregator module pass Coder Review.

Comment	File	Size	Author
#2	make_aggregator_module_pass_coder_review-2567365-2.patch	40.46 KB	tatarbj

Comments

Comment #1

12 September 2015 at 09:16

tatarbj created an issue. See original summary.

Comment #2

tatarbj

Hungarian

Brussels

commented 12 September 2015 at 09:20

Status:

Active

» Needs review

Status	File	Size
new	make_aggregator_module_pass_coder_review-2567365-2.patch	40.46 KB

I attach my patch which contains almost all of the fixed coding standards errors and warnings, except these:

phpcs --standard=Drupal -- core/modules/aggregator/
FILE: ...tor/src/Plugin/Field/FieldFormatter/AggregatorTitleFormatter.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------


FILE: ...gator/src/Plugin/Field/FieldFormatter/AggregatorXSSFormatter.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------


FILE: ...docs/drupal/core/modules/aggregator/src/Plugin/views/row/Rss.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 31 | ERROR | Class property $base_table should use lowerCamel naming
    |       | without underscores
 38 | ERROR | Class property $base_field should use lowerCamel naming
    |       | without underscores
----------------------------------------------------------------------


FILE: ...gator/tests/src/Unit/Plugin/AggregatorPluginSettingsBaseTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------


FILE: ...r/tests/src/Unit/Plugin/migrate/source/d6/AggregatorFeedTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 86 characters
----------------------------------------------------------------------


FILE: ...r/tests/src/Unit/Plugin/migrate/source/d6/AggregatorItemTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 86 characters
----------------------------------------------------------------------


Time: 3.54 secs; Memory: 16.25Mb

Those warning are unfixable because they contain the classnames which are too long ones. #2530920: Over-aggressive line length chokes on annotations
The errors in rss.php file is a deeper problem with historical cases that's why i was not able to rename those properties.