The 'Fast 404 pages' example in sites/default/default.settings.php still mentions $conf while the code below it has $config.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug, wrong docs now
Issue priority Normal, it doesn't break anything/td>
Unfrozen changes Unfrozen because it only changes strings/documentation.
CommentFileSizeAuthor
#9 Screen Shot update_fast_404_comment-2566925-8.png198.93 KBoheller
#2 update_fast_404_comment-2566925-2.patch1.34 KBhelmo

Comments

helmo created an issue. See original summary.

helmo’s picture

helmo commented
Status: Active » Needs review
StatusFileSize
new update_fast_404_comment-2566925-2.patch1.34 KB

Status: Needs review » Needs work

The last submitted patch, 2: update_fast_404_comment-2566925-2.patch, failed testing.

Status: Needs work » Needs review

helmo queued 2: update_fast_404_comment-2566925-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: update_fast_404_comment-2566925-2.patch, failed testing.

helmo’s picture

helmo commented
Status: Needs work » Needs review

As this patch only changes a comment I expect that it was a hick-up yesterday.

helmo queued 2: update_fast_404_comment-2566925-2.patch for re-testing.

oheller’s picture

oheller commented
Status: Needs review » Reviewed & tested by the community

Looks good. I was able to apply the patch and the documentation now matches.

oheller’s picture

oheller commented
StatusFileSize
new Screen Shot update_fast_404_comment-2566925-8.png198.93 KB

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: update_fast_404_comment-2566925-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community

Its green

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6a8c02d and pushed to 8.0.x. Thanks!

  • alexpott committed 6a8c02d on 8.0.x 
    Issue #2566925 by helmo: Update fast_404 comment in default.settings.php

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.