move views_ui.admin.theme.css to seven

There are no changes/regressions after the patch has been applied.

Did anyone had a look how the views UI looks afterwards in stark/bartik?

It doesn't seem like it. Tagging for screenshots

Here are screenshots for Classy and Bartik.

Classy before

Classy after

Bartik before

Bartik after

Mh so do we really want to make way worse for other people?

In my previous response I was thinking: wow this is a big regression, its horrible etc. but on the other hand its exactly how themes by default should behave.
The UI is still kinda usable, just look at classy for a while. The dropbutton style is odd, but well its still usable and actually kinda makes even more sense semantically than
placing it beside as in seven.

All in all we should think about maybe providing some common CSS file admin themes can include from views to get a somehow similar look and feel than with seven.

Updating to Need Review to re-test the patch.

Its worked Fine in firebox.

Its works perfectly without applying any patches

Move view_ui.admin.theme.css to seven theme

In order to make it clear the way forward for this issue, I'm re-uploading patch #2 which is still the correct patch (and applies cleanly).

This was RTBCed already on #15, but since a long time has passed, retesting the patch would be a good idea.

We'll need some screenshots before/after like on #13.

re-rolled the patch

Thanks @harsha012, looks like #38 is incorrect, please reroll based on patch #31.

@Manuel Garcia ,

I have moved the views_ui.admin.theme.css files from view_ui module to seven theme with images as per the patch.

Added test for patch #40 ;)

Re-roll of patch in #31.

Screenshots for bartick stark and seven

We can remove this CSS from core, but it's already in Stable so it's effectively already in Seven, because Seven > Classy > Stable.

So if the patch just does the removal of the CSS from core and associated changes I'm fine with it, but I strongly suspect this patch is adding (and loading) redundant files.

Worth mentioning is that this issue predates #2575421: Add a Stable base theme to core and make it the default if a base theme is not specified (and #2581443: Make Classy extend from the new Stable base theme), so this and related issues probably need to be rethought given Stable wasn't in place when this issue was created.

I'll be applying patch shortly for 9.1.x-dev.

Re-roll of #45 patch.

working on it

Here is the fixed review the patch attached before after patch screen shot for the reference.

Rerolled patch for 9.1.x

Please review this patch.

Thanks!

#69 is working fine on 9.1

Patch #69 is working fine on drupal 9.1 rolling up patch for 9.2.x-dev

Please review.

Thanks!

Reroll the patch for the 9.5.x version as per the patch for #69 and #72 as found that #69 works great in both 9.5.x and 9.4.x version, As we know that Seven is now deprecated for the version 10 with few more themes and known that claro is the default theme, So this issue is not for that, please let me know if i'm wrong in this.. So i'm reroll the patch for 9.5.x

That's can't be backported to 9.5

reroll for 9.5.x, #72

Updated patch and deleted the views_ui.admin.theme.css file and fixing #81

Postponed because

• Seven is no longer in core (so at minimum an issue summary is needed), Claro would likely be the current equivalent.
• Super-starkening is not necessarily the priority it once was, and this issue was filed 8 years ago. Given that this asset moving might be disruptive, it would be good to consider if the change is beneficial enough to justify that disruption.

Wonder if this is still needed?

Wonder if this is still needed?

I'll make the call. These CSS moving efforts were worth pursuing when Drupal 8 was in development - but now that it's been around close to a decade such a change would be more disruptive than beneficial.

Thanks!