Working on SafeMarkup and escaping issues are running tests from the command line is painful because assertion messages have html entities escaped. Let's offer a --non-html flag so that we can toggle this.

Before

Pass      Other      ConfigInstallTest  229 Drupal\config\Tests\ConfigInstallTe
    Value 'en' is equal to value 'en'.
Pass      Other      ConfigInstallTest  233 Drupal\config\Tests\ConfigInstallTe
    Value 'fr' is equal to value 'fr'.
Pass      Other      ConfigInstallTest  237 Drupal\config\Tests\ConfigInstallTe
    Value 'fr' is equal to value 'fr'.

After

Pass      Other      ConfigInstallTest  229 Drupal\config\Tests\ConfigInstallTe
    Value 'en' is equal to value 'en'.
Pass      Other      ConfigInstallTest  233 Drupal\config\Tests\ConfigInstallTe
    Value 'fr' is equal to value 'fr'.
Pass      Other      ConfigInstallTest  237 Drupal\config\Tests\ConfigInstallTe
    Value 'fr' is equal to value 'fr'.
CommentFileSizeAuthor
#2 2566319.2.patch1.83 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2566319.2.patch1.83 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

<3 <3 <3

stefan.r’s picture

stefan.r commented

Nice!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2566319.2.patch, failed testing.

Status: Needs work » Needs review

alexpott queued 2: 2566319.2.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

random pifr 0 byte fail.

effulgentsia’s picture

effulgentsia commented
Status: Reviewed & tested by the community » Fixed

Looks quite sensible to me. Pushed to 8.0.x.

  • effulgentsia committed da501fe on 8.0.x 
    Issue #2566319 by alexpott: run-tests.sh should have a non-HTML mode
effulgentsia’s picture

effulgentsia commented

Hm, we now have 'xml', 'non-html', and 'browser' as available args, but not all combinations of those are sensible. Not sure if we want a follow-up to either normalize those to a different set of args, or warn when a non-sensible combination is chosen.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

OMG YES!

alexpott++

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@effulgentsia --all and --class don't make sense together either - I think it is okay to leave this up to the caller.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@effulgentsia also --non-html does not affect the html generated for --browser so I think we're okay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.