https://www.drupal.org/node/2565259#comment-10313175 revealed that there is a shortage of fails being reported. Too many failed element children are being attached to the xml output, when the fails should be concatenated together into one fail message.

CommentFileSizeAuthor
#7 2566265.diff1.69 KBdrumm

Comments

Mixologic created an issue. See original summary.

  • Mixologic committed a1d2318 on 2566265-junit-xml-only-displays-first-fail 
    Issue #2566265: Fixes junit xml output parsing to include all failure...

  • Mixologic committed 52f83ea on 2566265-junit-xml-only-displays-first-fail 
    Issue #2566265: Prevents Undefined Variable notices.
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Active » Needs review

This is fixed on the branch.

Before:
https://dispatcher.drupalci.org/job/DCI_XML/108/testReport/
https://dispatcher.drupalci.org/job/DCI_XML/108/testReport/Update/Drupal...

After:
https://dispatcher.drupalci.org/job/DCI_XML/110/testReport/
https://dispatcher.drupalci.org/job/DCI_XML/110/testReport/Update/Drupal...

dawehner’s picture

dawehner
Primary language German
commented

Nice! Does this also automatically deals with the segfault?

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

dahwehner: no, the segfaults are different. If a php fatal or a segfault happens in a unit test, drupalci doesnt display those anywhere but on the console output right now, primarily because it doesnt know about them. This just fixes the output when there is more than one assertion failing/throwing an exception within the same test method.

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new 2566265.diff1.69 KB

Looks okay, but the whitespace was bothering me a bit, patch attached.

  • Mixologic committed dd01ef1 on 2566265-junit-xml-only-displays-first-fail 
    Issue #2566265: Fixes indenting
basic’s picture

basic commented
Status: Needs review » Reviewed & tested by the community

Looks good with the whitespace fixes

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

This has been in prod for a bit. Works.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.