#2529560: Expand support for link objects landed, now let's use it for \Drupal\Core\Breadcrumb\Breadcrumb, so that we have >1 example of RenderableInterface being used.

CommentFileSizeAuthor
#4 interdiff.txt613 byteswim leers
#4 2565925-4.patch1.19 KBwim leers
#2 2565925-2.patch1.09 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2565925-2.patch1.09 KB
nlisgo’s picture

nlisgo commented

Would it be appropriate to use the @inheritdoc here?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2565925-4.patch1.19 KB
new interdiff.txt613 bytes

Absolutely, great point!

Status: Needs review » Needs work

The last submitted patch, 4: 2565925-4.patch, failed testing.

Wim Leers queued 4: 2565925-4.patch for re-testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2565925-4.patch, failed testing.

Crell’s picture

Crell commented

Not sure what the fails are, but +5 to using RenderableInterface here.

nlisgo queued 4: 2565925-4.patch for re-testing.

nlisgo’s picture

nlisgo commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice

Nice!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committing this under the followup proviso in the beta evaluation policy. Committed e03e4e8 and pushed to 8.0.x. Thanks!

  • alexpott committed dc29644 on 8.0.x 
    Issue #2565925 by Wim Leers: Let Breadcrumb implement...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.