It's probably time to consider if Wysiwyg Media Embed should be released for Drupal 8. We have a different situation now where CKeditor is now in core and the WYSIWYG module is apparently going away, so it would need to hook onto the new WYSIWYG core framework. Additionally we might have to have a fork of the MediaEmbed library itself in order to accommodate some very reasonable requests. If anyone has a good handle on the WYSIWYG framework I would appreciate insights.

Glad to see the 7.x module is increasingly popular since the small patches posted in December and I would like to keep helping if possible. Also a testing framework for this would be thrilling as well - any takers?

CommentFileSizeAuthor
#5 drupal8-2565765-5.patch2.38 KBhongpong

Comments

HongPong created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Active » Needs review

I needed this button for a Drupal 8 project, so I ported it.

https://github.com/agaric/mediaembedbutton

Not sure if we should create another project because this is not longer for the WYSIWYG module but for the core's ckeditor module.

What do you think?

The code is here:

https://github.com/agaric/mediaembedbutton

Thanks!

hongpong’s picture

hongpong commented

Thank you gnuget, I would be fine with applying this code to an 8.x branch. I think we can bend the definition a little bit since this improves the 'wysiwyg' capabilities, if not using that particular bit of glue from the old days. Would like to have another person review it as well, but this looks great!

gnuget’s picture

gnuget
Primary language Spanish
commented

In the meanwhile, can you please create an 8.x branch and a dev-8.x tag with the code so other users can start testing it and reporting bugs and we can start using d.o to report bugs and provide patches instead of GitHub?

And when you feel comfortable to release it we can include it here: https://www.drupal.org/docs/8/core/modules/ckeditor/contributed-modules-...

Thanks!

hongpong’s picture

hongpong commented
StatusFileSize
new drupal8-2565765-5.patch2.38 KB

Ok here is the patch I'm going to put it on. I rewrote the machine names and fixed the readme, I think it is good to go.

hongpong’s picture

hongpong commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Fixed

Closing this since we have 8.x-1.x-dev now. Further issues should be opened under that classification. Thank you!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.