There are a few CSS files already in Classy. They have .theme. in their file names, because those were the names when the files were moved. We original were going to work with a two step process of copying everything to Classy and then rename/reorganize everything. We are too close to release to use a two step process. Other CSS that is being copied will have the correct names and folders. This issue is to clean up the ones that are already there.

See attached screenshot.

1) Remove the .theme. from the file names.
2) Move them from the folders they are in now, which were named similar to the template folders, and put them into an appropriate folder named for the category they are in. It looks like the three there now belong in css/theme since they are added in the theme category.

Optionally:
1) See if these should be moved to component.
2) Evaluate the library names. The comment library doesn't need to be called 'drupal.comment.threaded' but that is what it was probably called when it was in the comment module. We could use a simpler name. But, if changing the library names is disruptive, leave it as-is.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because nothing is broken
Issue priority Not critical because nothing is broken
Prioritized changes The main goal of this issue is put Classy's files into a more shippable state.
Disruption For most existing 8 sites there should be no disruption. Any disruption for fringe cases would be easily fixed.
CommentFileSizeAuthor
#2 clean_up_existing_css-2565719-2.patch2.92 KBLewisNyman
folderstructureandcss.png107.58 KBdavidhernandez
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidhernandez created an issue. See original summary.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Active » Needs review
Issue tags: +frontend
FileSize
clean_up_existing_css-2565719-2.patch2.92 KB

I think you will like this patch:

  1. Bye bye .theme.
  2. CSS files renamed to match the names of the components within them
  3. Libraries renamed to match the name of the CSS files
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented
Issue summary: View changes
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented 
+++ b/core/themes/classy/classy.libraries.yml
@@ -7,14 +7,14 @@ base:
-drupal.comment.threaded:
+indented:
...
+      css/components/indented.css: {}

Oh, good call.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Needs review » Postponed

Postponed on: #2566597: [Mega patch] Move system *.theme.css files to Classy

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented
Status: Postponed » Closed (fixed)

This was completed in the other issue.