There's a misspelling that slipped into head (Well, homonym confusion on my part)

// Now test with an error message to insure it is correctly passed

"insure" should be "ensure" there.

Issue tagged as novice and quick fix since this is an excellent case for someone just getting used git and making patch files to tackle.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Aki Tendo created an issue. See original summary.

Aki Tendo’s picture

Title: Misspelling in Drupal\Component\Assertion\Handle comments » Misspelling in core/modules/simpletest/src/Tests/SimpleTestTest.php
joyceg’s picture

Assigned: Unassigned » joyceg
joyceg’s picture

This issue is not seen in the given file.

Aki Tendo’s picture

Just checked, it's still there.

Line 177 of the file core/modules/simpletest/src/Tests/SimpleTestTest.php

For context, here's the surrounding code.

    catch (\AssertionError $e) {
      try {
        // Now test with an error message to insure it is correctly passed
        // along by the rethrow.
        assert(FALSE, 'Lorem Ipsum');
      }
      catch ( \AssertionError $e ) {
        $this->assertEqual($e->getMessage(), 'Lorem Ipsum', 'Runtime assertions Enabled and running.');
      }
    }

Note - this error got popped in only a couple days ago - to see it (and do development on Drupal in general) you need to check out core from git: https://www.drupal.org/project/drupal/git-instructions

The packaged beta releases only occur once a month, and they rapidly fall behind the repository HEAD.

joyceg’s picture

Adding the patch here.

joyceg’s picture

Status: Active » Needs review
Aki Tendo’s picture

Status: Needs review » Reviewed & tested by the community

K, looks good. I'll go ahead and mark as RTBC now since we're only dealing with comment text. Congratulations on your first patch.

joyceg’s picture

Thank you for your help Aki Tendo.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed e85b2ac on 8.0.x
    Issue #2565671 by joyceg, Aki Tendo: Misspelling in core/modules/...
webchick’s picture

Component: base system » documentation

Oops, also crediting Aki Tendo, and moving to Documentation component.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.