Problem/Motivation

Twig 1.21.2 is out.

Proposed resolution

Update it

Remaining tasks

Do it

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#7 vendor-twig_1.21.2-2565669-2.patch20.51 KBplach
#2 vendor-twig_1.21.2-2565669-2.patch20.51 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach created an issue. See original summary.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach for Drupal Association commented
Status: Active » Needs review
Issue tags: +D8 Accelerate
FileSize
vendor-twig_1.21.2-2565669-2.patch20.51 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Even minor updates are critical now?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Critical » Major

Patch-level updates aren't critical unless they're a fix for something that would be considered critical if the code was in core. Skipping a patch-level update we shouldn't even notice if the library is doing semver right.

Major and minor updates we should treat as critical (probably until the end of RC then monitor very closely after that) so that we don't fall behind though. Falling behind with minor/major updates can mean real technical debt which makes it harder to update later.

So I think that makes this major, http://symfony.com/blog/twig-1-21-2-released looks superficially serious but I think we'd have noticed if that affected us.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach for Drupal Association commented

What's concerning is that also this patch is segfaulting in the MigrateTermNodeRevisionTest test. Maybe there's something wrong with my patches?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: vendor-twig_1.21.2-2565669-2.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach for Drupal Association commented
FileSize
vendor-twig_1.21.2-2565669-2.patch20.51 KB
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach for Drupal Association commented
Status: Needs work » Needs review
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach for Drupal Association commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 5fc2499 on 8.0.x 
    Issue #2565669 by plach: Update Twig to 1.21.2
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented

Let's see us at #2555243: Upgrade path / plan to Twig 2.x aka 2.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.