Follow-up to #2533360: Upgrade to Symfony 2.7.2

Symfony 2.7.4 is now released.

Have a skim of the issue summary on #2454393: Upgrade to Symfony 2.6.5 for a better overview of why upgrading point releases is a good idea :).

This has no known security fixes, but several DX improvements. See #2400407-42: [meta] Ensure vendor (PHP) libraries are on latest stable release.

Changelog changelog.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is an external library upgrade.
Issue priority Critical because it is an external library update which should be completed before RC. See #2400407: [meta] Ensure vendor (PHP) libraries are on latest stable release.
Disruption Not disruptive.
CommentFileSizeAuthor
#14 upgrade_to_symfony_2_7_4-2565337-14.patch391.06 KBhussainweb
#7 upgrade_to_symfony_2_7_4-2565337-7.patch391.71 KBhussainweb
#2 2565337.patch406.54 KBjoshtaylor

Comments

joshtaylor created an issue. See original summary.

joshtaylor’s picture

joshtaylor commented
StatusFileSize
new 2565337.patch406.54 KB
joshtaylor’s picture

joshtaylor commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2565337.patch, failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Major » Critical

This is something we'll want to do before RC. Escalating to critical.

RavindraSingh’s picture

RavindraSingh commented

Release Notes - http://symfony.com/blog/symfony-2-7-4-released
Seems there are a lot of bugs has been fixed, we should also list down the which all sections of Drupal 8 will impact.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_to_symfony_2_7_4-2565337-7.patch391.71 KB

This patch should work. See #2531798: Handle binary files in patches for details.

hussainweb’s picture

hussainweb
Primary language English
commented

BTW, just FYI, I reused the patch I had created for #2565363: Upgrade to Symfony 2.7.4, which was a duplicate.

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes
Parent issue: » #2400407: [meta] Ensure vendor (PHP) libraries are on latest stable release
chx’s picture

chx commented
Issue tags: +Needs issue summary update

The issue summary says "This has no known security security fixes" and the beta evaluation says "Major because this release contains security fixes". Please fix. (Also WTF @ major because security! That should say critical because security but since it's critical already that's a bit moot.)

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes
Issue tags: -Needs issue summary update

It must be a copy from the previous issue.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Reading the release notes it even seems to be nothing which affects Drupal

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Unfortunately this will need a small re-roll thanks to #2563799: Upgrade Guzzle to a tagged release. I debated putting this one in first, but decided it was probably better to get that one closed for good.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_to_symfony_2_7_4-2565337-14.patch391.06 KB

Fresh patch.

hussainweb’s picture

hussainweb
Primary language English
commented
Issue tags: -Needs reroll
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

It is still super odd how big these changes to composer.lock / install.json actually can be.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ok, great. Let's get this in.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed c1be7e7 on 8.0.x 
    Issue #2565337 by hussainweb, joshtaylor: Upgrade to Symfony 2.7.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Do we have symfony v2.7.5 upgrade issue yet? I'm unable to find one.

hussainweb’s picture

hussainweb
Primary language English
commented

Created #2578805: Upgrade to Symfony 2.7.5