SqlContentEntityStorage::setEntityType was introduced as a temporary measure by #2337927: SqlContentEntityStorage::onFieldStorageDefinition(Create|Update|Delete)() is broken for base fields and was marked @deprecated, for removal before Drupal 8.0.0 at the time it was first committed. Unfortunately, the required refactoring still hasn't happened (#2274017: Make SqlContentEntityStorage table mapping agnostic ) and is unlikely to happen in time for the function to actually be removed.

Internally the function is only used by Entity API, and there should be no contrib modules using it as it was always marked @deprecated. We should mark it @internal so it can be removed in a point release of Drupal 8.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Unfrozen changes Unfrozen because it only changes documentation
Prioritized changes The main goal of this issue is correcting documetation for code already deprecated for 8.0.0
Disruption Not disruptive since we are just changing documentation from one way of saying "do not use" to another.
CommentFileSizeAuthor
#4 2274017-4-setEntity-internal.patch845 bytesianthomas_uk
#2 2274017-2-setEntity-internal.patch844 bytesianthomas_uk

Comments

ianthomas_uk created an issue. See original summary.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Assigned: ianthomas_uk » Unassigned
Status: Active » Needs review
StatusFileSize
new 2274017-2-setEntity-internal.patch844 bytes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented 
+++ b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php
@@ -258,8 +258,8 @@ protected function getStorageSchema() {
+   * @internal Only to be used internally by Entity API. Expected to be
+   *   removed by https://www.drupal.org/node/2274017

Looks good, unfortunately it's missing the trailing dot :)

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
StatusFileSize
new 2274017-4-setEntity-internal.patch845 bytes

I tend to leave them off after URLs, but I guess that is the standard.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Thanks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 56993d4 and pushed to 8.0.x. Thanks!

  • alexpott committed 56993d4 on 8.0.x 
    Issue #2565307 by ianthomas_uk: Document SqlContentEntityStorage::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.