When a node type has its RH behaviour set to 'not found', the node title is still shown as the page title, both as the TITLE html element and within the page.

CommentFileSizeAuthor
#4 rabbit_hole-node-title-2564751-3-D7.patch379 byteseddie_c
#2 2564751.rabbit_hole.not-found-page-title.patch453 bytesjoachim

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2564751.rabbit_hole.not-found-page-title.patch453 bytes

drupal_not_found() only sets the title if the site has a 404 page defined, so I think the best thing is for RH to set the not found title itself. If site_404 IS set, drupal_not_found() will set the title again later.

olofbokedal’s picture

olofbokedal commented
Status: Needs review » Closed (outdated)

Closing this since the 6.x branch isn't supported anymore.

eddie_c’s picture

eddie_c commented
StatusFileSize
new rabbit_hole-node-title-2564751-3-D7.patch379 bytes

I'm not sure that this is outdated. The behaviour seems to be the same in the 7.x branch: When you visit a node whose behaviour is set to 'not found' the resulting 404 page shows the node title.

@joachim's patch addresses this for me. I've re-rolled it for 7.x-2.x

eddie_c’s picture

eddie_c commented
Status: Closed (outdated) » Needs review
eddie_c’s picture

eddie_c commented
Version: 6.x-1.x-dev » 7.x-2.x-dev

  • Matroskeen committed f2acc54 on 7.x-2.x authored by eddie_c 
    Issue #2564751 by joachim, eddie_c: node title is shown for 'not found'...
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs review » Fixed

Well, I wasn't able to reproduce the issue, but committed for two reasons:
1) I think it might be some case when it happens;
2) Additional drupal_set_title() It won't hurt anyway :)

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.