As a pre-requisite to #2484119: Create a 'syntax linting' build step plugin, the 'patch' plugin should be improved so that it i) ensures that the actual patch file exists, ii) Fails gracefully when a patch does not apply, and iii) logs what files have been changed when a patch is successfully applied.

CommentFileSizeAuthor
#6 improve_patch_process_v2.patch12.35 KBjthorson
#5 improve_patch_process.patch13.52 KBjthorson

Comments

jthorson created an issue. See original summary.

jthorson’s picture

jthorson commented
Title: Imrpove 'patch' process » Improve 'patch' process
jthorson’s picture

jthorson commented

First cut pushed to 2564655-improve-patch-process branch (second to last commit).

Working on refactoring so that we can store modified files per patch, and move to using git diff to determine modified files. Need to move to 'per patch' because the git diff needs to occur within the same git branch as the patch was applied in, and we may have multiple git trees in a single codebase.

  • jthorson committed d3f36fa on 2564655-improve-patch-process 
    Issue #2564655 by jthorson: Improve patch process.
jthorson’s picture

jthorson commented
Status: Active » Needs review
StatusFileSize
new improve_patch_process.patch13.52 KB

New Patch class implemented and pushed to branch. Ready for review.

jthorson’s picture

jthorson commented
StatusFileSize
new improve_patch_process_v2.patch12.35 KB

  • jthorson committed 1a5d90d on 2564655-improve-patch-process 
    Issue #2564655 by jthorson: Code style cleanup

  • basic committed ce8629b on 2564655-improve-patch-process 
    Revert "Issue #2564655 by jthorson: Code style cleanup"

The code format...
basic’s picture

basic commented
Status: Needs review » Reviewed & tested by the community

I've reviewed this code, and understand how it works. It looks good so I'm merging to dev, but there should be a related issue for code style cleanup.

jthorson’s picture

jthorson commented
Related issues: +#2574965: JobCodeBase Docblock cleanups

Related issue for docblock cleanup

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Issue tags: +Needs deployment
isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs deployment

dev has been merged into production, and production is live.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.