This styling was originally introduced in #563390: Seven theme lacks formatting on common html elements such as lists, paragraphs & <code> + #634218: Seven theme: CODE elements are too small when the base font size of Seven was smaller. This styling now makes the text elements oversized:
If we remove this styling then the text is the regular base size:
Create patch
Review
Code/pre/kbd tags now match base font size.
None
None
| Issue category | Task because coding standards |
|---|---|
| Issue priority | Not critical because coding standards |
| Unfrozen changes | Unfrozen because it only changes CSS |
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | core-remove_seven_font_size_for_text_elements-2564421-5-8.0.x.patch | 374 bytes | jaxxed |
| Screenshot 2015-09-07 16.45.31.jpg | 703.36 KB | lewisnyman | |
| Screenshot 2015-09-07 16.45.29.jpg | 749.52 KB | lewisnyman |
Comments
Comment #2
sixzeronine commentedComment #3
sixzeronine commentedComment #4
jaxxed commentedComment #5
jaxxed commentedRemoved the font-size declaration in the seven theme, for the text elements.
no screenshot attached, as it was a quick patch, and the declaration shown in the screenshot was easy to find.
Comment #6
bruvers commentedLooks good. With this patch
normalize.csskicks in and setscode, kbd, pre { font-size: 1em; }. Thefont-sizeof all three elements now is the same as the base font size.Comment #7
alexpottCommitted 87f510f and pushed to 8.0.x. Thanks!