In core/lib/Drupal/Core/File/MimeType/MimeTypeGuesser.php on line 122 we are calling SymfonyMimeTypeGuesser::reset();. This wasn't added to HttpFoundation until version 2.7.2 but in composer.json we are specifiying 2.7.*

I propose replacing "2.7.*" with "~2.7.2".

CommentFileSizeAuthor
#17 httpfoundation_version-2563139-17.patch946 bytestimmillwood
#13 httpfoundation_version-2563139-13.patch943 bytesnikolay shapovalov
#6 httpfoundation_version-2563139-6.patch943 bytesnikolay shapovalov
#2 httpfoundation_version-2563139-2.patch2.86 KBtimmillwood

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new httpfoundation_version-2563139-2.patch2.86 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

sure why not

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: httpfoundation_version-2563139-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs reroll

.

nikolay shapovalov’s picture

nikolay shapovalov commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new httpfoundation_version-2563139-6.patch943 bytes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Needs issue summary update

Sorry, what is the bug here?

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Reviewed & tested by the community

@jibran - The bug is that drupal 8 depends on HttpFoundation 2.7.2 or higher and the composer.json allows 2.7.0 or 2.7.1.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: httpfoundation_version-2563139-6.patch, failed testing.

Status: Needs work » Needs review

zniki.ru queued 6: httpfoundation_version-2563139-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: httpfoundation_version-2563139-6.patch, failed testing.

nikolay shapovalov’s picture

nikolay shapovalov commented
Assigned: Unassigned » nikolay shapovalov
Issue tags: +Needs reroll
nikolay shapovalov’s picture

nikolay shapovalov commented
Assigned: nikolay shapovalov » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new httpfoundation_version-2563139-13.patch943 bytes
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 13: httpfoundation_version-2563139-13.patch, failed testing.

The last submitted patch, 13: httpfoundation_version-2563139-13.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new httpfoundation_version-2563139-17.patch946 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Tim, run faster than the commits!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c382ead and pushed to 8.0.x. Thanks!

  • alexpott committed c382ead on 8.0.x 
    Issue #2563139 by timmillwood, zniki.ru: HttpFoundation version...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.